From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jeff King <peff@peff.net>
Cc: Geoffrey Irving <irving@naml.us>,
git@vger.kernel.org, Lars Hjemli <hjemli@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: bug with .git file and aliases
Date: Tue, 11 Aug 2009 12:04:06 +0200 [thread overview]
Message-ID: <4A814216.20708@drmicha.warpmail.net> (raw)
In-Reply-To: <20090720152117.GB5347@coredump.intra.peff.net>
Jeff King venit, vidit, dixit 20.07.2009 17:21:
> On Mon, Jul 20, 2009 at 09:54:12AM -0400, Geoffrey Irving wrote:
>
>> git 1.6.3.3 has a bug related to .git file support and aliases.
>> Specifically, if you make an alias for status and call it from a
>> subdirectory, git status chdirs into the true .git dir but then
>> chdir's back to the wrong place in order to run the lstats for status.
>> The result is that git status thinks all files have disappeared.
>
> Yeah, this is a known problem. The problem is that the 'git' wrapper
> sets up the environment only partially when running aliases, and then
> the resulting command ends up confused about where the worktree is. I
> really don't remember the specifics, but you can probably find some
> discussion in the list archives. Fixing it, IIRC, required some
> refactoring of the setup code (which I had hoped to get to at some
> point, but I am way behind on my git todo list).
>
> Hmm. Poking around a bit, this seems related, but I don't know why I
> never followed up:
>
> http://article.gmane.org/gmane.comp.version-control.git/72792
>
> -Peff
...because it was up to the brave git-on-win folks to decide whether
setenv() on win would be rewritten to not use putenv() when the value is
"". J&J, has anything happened on the front or is it likely to? (I'm
sorry I can't offer help, only moral support...)
Jeff's patch from Feb. 08 still applies more or less cleanly (with
obvious adjustments) and makes the relevant tests pass (on Linux).
Michael
next prev parent reply other threads:[~2009-08-11 12:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 13:54 bug with .git file and aliases Geoffrey Irving
2009-07-20 14:04 ` Santi Béjar
2009-07-20 14:27 ` Geoffrey Irving
2009-07-20 15:18 ` Santi Béjar
2009-07-20 15:25 ` Geoffrey Irving
2009-07-20 15:21 ` Jeff King
2009-08-10 20:22 ` Geoffrey Irving
2009-08-10 23:05 ` Johannes Schindelin
2009-08-11 3:37 ` Geoffrey Irving
2009-08-11 8:33 ` Johannes Schindelin
2009-08-11 10:04 ` Michael J Gruber [this message]
2009-08-11 10:26 ` Johannes Sixt
2009-08-11 10:37 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A814216.20708@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
--cc=irving@naml.us \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).