From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Pat Thoyts <patthoyts@googlemail.com>,
Frank Li <lznuaa@gmail.com>,
git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: [msysGit] quick question about __stdcall at run-command.c mingw.c
Date: Mon, 17 Aug 2009 10:43:44 +0200 [thread overview]
Message-ID: <4A891840.4050403@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0908171018490.4991@intel-tinevez-2-302>
Johannes Schindelin schrieb:
> On Mon, 17 Aug 2009, Johannes Sixt wrote:
>> Pat Thoyts schrieb:
>>> 2009/8/17 Frank Li <lznuaa@gmail.com>:
>>>> I am tring to clear VC build patch.
>>>>
>>>> I found __stdcall position break MSVC build.
>>>>
>>>> static __stdcall unsigned run_thread(void *data)
>>>>
>>>> MSVC require __stdcall should be between return type and function
>>>> name. like static unsigned __stdcall run_thread(void *data)
>>>>
>>>> I think msys gcc should support MSVC format.
>
> I think that it does.
>
> But it is _your_ duty to check.
Cool down. Asking for "please could you check whether this works" *if* you
don't have the infrastructure to test it yourself is certainly dutyful enough.
Do you have an Irix, Solaris, HP box on your desk next to your Linux, so
that you don't have to ask others to test your patches?
-- Hannes
next prev parent reply other threads:[~2009-08-17 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 23:19 quick question about __stdcall at run-command.c mingw.c Frank Li
2009-08-17 0:03 ` [msysGit] " Pat Thoyts
2009-08-17 7:52 ` Johannes Sixt
2009-08-17 8:21 ` Johannes Schindelin
2009-08-17 8:43 ` Johannes Sixt [this message]
2009-08-17 9:12 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A891840.4050403@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox