From: Paolo Bonzini <bonzini@gnu.org>
To: Frank Li <lznuaa@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH 05/11] Remove va_copy at MSVC because there are va_copy.
Date: Mon, 17 Aug 2009 18:53:59 +0200 [thread overview]
Message-ID: <4A898B27.3040507@gnu.org> (raw)
In-Reply-To: <1250525040-5868-1-git-send-email-lznuaa@gmail.com>
On 08/17/2009 06:04 PM, Frank Li wrote:
> MSVs have not implemented va_copy. remove va_copy at MSVC environment.
> It will malloc buffer each time.
... but only a 257-byte buffer as dscho pointed out.
In many places that do not have va_copy, a simple assignment works. And
va_end is almost always a no-op. So what about
#ifndef va_copy
#define va_copy(dst, src) ((dst) = (src))
#endif
if it works on MSVC?
Paolo
next prev parent reply other threads:[~2009-08-17 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 16:04 [PATCH 05/11] Remove va_copy at MSVC because there are va_copy Frank Li
2009-08-17 16:49 ` Johannes Schindelin
2009-08-17 18:22 ` Joshua Jensen
2009-08-17 16:53 ` Paolo Bonzini [this message]
2009-08-17 16:56 ` Reece Dunn
2009-08-17 17:02 ` Erik Faye-Lund
2009-08-17 17:26 ` Erik Faye-Lund
2009-08-17 19:46 ` Johannes Schindelin
2009-08-18 5:06 ` Frank Li
2009-08-18 9:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A898B27.3040507@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox