From: Ian Clatworthy <ian.clatworthy@canonical.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git List <git@vger.kernel.org>, Matt McClure <mlm@aya.yale.edu>,
Miklos Vajna <vmiklos@frugalware.org>,
Julian Phillips <julian@quantumfyre.co.uk>,
vcs-fast-import-devs@lists.launchpad.net
Subject: Re: [PATCH v6 5/6] fast-import: add option command
Date: Fri, 04 Sep 2009 13:42:26 +1000 [thread overview]
Message-ID: <4AA08CA2.4060702@canonical.com> (raw)
In-Reply-To: <fabb9a1e0909022155r254c41c6s9ed962313c241e9@mail.gmail.com>
Sverre Rabbelier wrote:
> Heya,
>
> On Thu, Sep 3, 2009 at 04:41, Junio C Hamano<gitster@pobox.com> wrote:
>> I think at least the function should be made conditional to die() if it
>> was called from parse_argv() but simply ignore unknown if it was called
>> from the input stream.
>
> Makes sense, what do the fast-import devs think?
Sounds ok to me.
Ian C.
prev parent reply other threads:[~2009-09-04 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 17:56 [PATCH v6 0/6] fast-import: add new feature and mark command Sverre Rabbelier
2009-09-02 17:56 ` [PATCH v6 1/6] fast-import: put option parsing code in separate functions Sverre Rabbelier
2009-09-02 17:56 ` [PATCH v6 2/6] fast-import: put marks reading in it's own function Sverre Rabbelier
2009-09-02 17:57 ` [PATCH v6 3/6] fast-import: add feature command Sverre Rabbelier
2009-09-02 17:57 ` [PATCH v6 4/6] fast-import: test the new " Sverre Rabbelier
2009-09-02 17:57 ` [PATCH v6 5/6] fast-import: add option command Sverre Rabbelier
2009-09-02 17:57 ` [PATCH v6 6/6] fast-import: test the new " Sverre Rabbelier
2009-09-03 2:41 ` [PATCH v6 5/6] fast-import: add " Junio C Hamano
2009-09-03 4:55 ` Sverre Rabbelier
2009-09-04 3:42 ` Ian Clatworthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA08CA2.4060702@canonical.com \
--to=ian.clatworthy@canonical.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julian@quantumfyre.co.uk \
--cc=mlm@aya.yale.edu \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
--cc=vcs-fast-import-devs@lists.launchpad.net \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).