From: Rogan Dawes <discard@dawes.za.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Gerrit Pape <pape@smarden.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: prevent 'git help' from searching for git repository
Date: Fri, 04 Sep 2009 11:43:30 +0200 [thread overview]
Message-ID: <4AA0E142.4080105@dawes.za.net> (raw)
In-Reply-To: <fabb9a1e0909020447p212594cake8c6fe3a43b667ec@mail.gmail.com>
Sverre Rabbelier wrote:
> Heya,
>
> On Wed, Sep 2, 2009 at 11:58, Gerrit Pape<pape@smarden.org> wrote:
>> + for i in $(git --git-dir=/nonexistent help -a|egrep '^ ')
>
> Wouldn't implementing "git --no-git-dir" be more appropriate?
>
Or documenting which git commands do/don't require a git dir at all?
I assume that documenting those that don't would be better than
documenting those that do . . .
And by documenting, I mean in the code, so that the code can DTRT.
Otherwise, having this switch lets people shoot themselves in the foot,
I'd think.
Rogan
next prev parent reply other threads:[~2009-09-04 9:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 9:58 [PATCH] git-completion.bash: prevent 'git help' from searching for git repository Gerrit Pape
2009-09-02 11:47 ` Sverre Rabbelier
2009-09-04 9:29 ` [PATCH 1/2] git: add new option --no-git-dir Gerrit Pape
2009-09-04 9:29 ` [PATCH 2/2] git-completion.bash: prevent 'git help' from searching for git repository Gerrit Pape
2009-09-04 9:57 ` Junio C Hamano
2009-09-04 10:22 ` Johannes Schindelin
2009-09-04 11:09 ` Gerrit Pape
2009-09-04 12:35 ` Johannes Schindelin
2009-09-04 12:49 ` Gerrit Pape
2009-09-04 12:52 ` Johannes Schindelin
2009-09-07 19:15 ` Junio C Hamano
2009-10-27 13:30 ` Gerrit Pape
2009-10-28 6:11 ` Junio C Hamano
2009-10-28 9:30 ` [PATCH] help -a: do not unnecessarily look for a repository Gerrit Pape
2009-10-28 20:26 ` Junio C Hamano
2009-09-04 9:43 ` Rogan Dawes [this message]
2009-09-04 10:32 ` [PATCH] git-completion.bash: prevent 'git help' from searching for git repository Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA0E142.4080105@dawes.za.net \
--to=discard@dawes.za.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pape@smarden.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).