From: Johannes Sixt <j.sixt@viscovery.net>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Update the usage bundle string.
Date: Thu, 17 Sep 2009 08:12:52 +0200 [thread overview]
Message-ID: <4AB1D364.1080701@viscovery.net> (raw)
In-Reply-To: <1253136011-12011-1-git-send-email-tfransosi@gmail.com>
Thiago Farina schrieb:
> @@ -11,6 +11,12 @@
>
> static const char *bundle_usage="git bundle (create <bundle> <git rev-list args> | verify <bundle> | list-heads <bundle> [refname]... | unbundle <bundle> [refname]... )";
Is this variable still used? Shouldn't it be removed?
> +static const char builtin_bundle_usage[] = "\
> + git bundle create <file> <git-rev-list args>\n\
> + git bundle verify <file>\n\
> + git bundle list-heads <file> [refname...]\n\
> + git bundle unbundle <file> [refname...]";
You indent the usage text. Do other commands do that, too? If you resend,
it may be worth using this style:
static const char builtin_bundle_usage[] =
"git bundle create <file> <git-rev-list args>\n"
"git bundle verify <file>\n"
...
i.e. not to use backslash-at-eol.
> - if (argc < 3)
> - usage(bundle_usage);
> + if (argc < 3)
> + usage(builtin_bundle_usage);
This re-indentation is an accident, isn't it?
-- Hannes
next prev parent reply other threads:[~2009-09-17 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 21:20 [PATCH] Update the usage bundle string Thiago Farina
2009-09-17 6:12 ` Johannes Sixt [this message]
2009-09-17 15:56 ` Thiago Farina
2009-09-17 16:04 ` Matthieu Moy
2009-09-17 16:16 ` Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB1D364.1080701@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).