From: Jason Holden <jason.k.holden@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Neil Roberts <bpeeluk@yahoo.co.uk>, git@vger.kernel.org
Subject: Re: [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject
Date: Tue, 22 Sep 2009 20:26:36 -0400 [thread overview]
Message-ID: <4AB96B3C.1040107@gmail.com> (raw)
In-Reply-To: <7vocp3t0oz.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
>
> I think we all agree that the behaviour should be improved, but I think
> neither Roger's patch nor Andreas's one was the solution.. People who
> care need to carry discussions and proposed patches forward to help us
> agree on an acceptable solution.
An additional use case for this is that at $dayjob, we use GForge
Advanced Server. With GForge, commits are tied to the bug-tracker
by including the bug-id in the commit message with the syntax
[#NNN], where NNN is a unique id for each submitted bug.
So the typical first line of a commit message looks something like:
[#100] Fix bug in foo.c
sent using git-send-email, this becomes
[PATCH] [#100] Fix bug in foo.c
But of course, both [PATCH] and [#100] get stripped off when applied
with git-am, forcing a manual edit.
The reg-expression stuff isn't necessary for my particular use-case.
Stripping off brackets that have any variant of "PATCH" in them, or
just stripping off the first set of brackets would work for me.
--
Regards,
Jason Holden
next prev parent reply other threads:[~2009-09-23 0:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 19:38 git mailinfo strips important context from patch subjects Roger Leigh
2009-06-28 20:02 ` Jeff King
2009-06-28 23:04 ` Junio C Hamano
2009-06-29 9:53 ` Andreas Ericsson
2009-06-29 9:55 ` [PATCH] mailinfo: Remove only one set of square brackets Andreas Ericsson
2009-06-29 16:09 ` Junio C Hamano
2009-06-30 5:33 ` Jeff King
2009-06-29 21:17 ` [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject Roger Leigh
2009-06-29 21:26 ` Jakub Narebski
2009-06-29 21:49 ` Roger Leigh
2009-09-22 10:39 ` Neil Roberts
2009-09-22 12:56 ` [PATCH] builtin-mailinfo.c: Improve the regexp for cleaning up the subject Neil Roberts
2009-09-22 16:15 ` [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject Junio C Hamano
2009-09-22 16:51 ` Neil Roberts
2009-09-23 0:26 ` Jason Holden [this message]
2009-06-29 21:34 ` [PATCH 2/2] builtin-mailinfo.c: Free regular expression after use Roger Leigh
2009-06-29 21:36 ` git mailinfo strips important context from patch subjects Roger Leigh
2009-06-28 20:07 ` [PATCH] " Paolo Bonzini
2009-06-29 9:19 ` Andreas Ericsson
2009-06-29 10:21 ` Paolo Bonzini
2009-06-29 10:54 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB96B3C.1040107@gmail.com \
--to=jason.k.holden@gmail.com \
--cc=bpeeluk@yahoo.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).