From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Giuseppe Scrivano <gscrivano@gnu.org>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer
Date: Sat, 26 Sep 2009 21:28:42 +0200 [thread overview]
Message-ID: <4ABE6B6A.4000400@lsrfire.ath.cx> (raw)
In-Reply-To: <87ske9cya9.fsf@master.homenet>
> diff --git a/diff.c b/diff.c
> index e1be189..e75f58e 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -901,7 +901,7 @@ static void show_stats(struct diffstat_t *data, struct diff_options *options)
>
> /* Find the longest filename and max number of changes */
> reset = diff_get_color_opt(options, DIFF_RESET);
> - set = diff_get_color_opt(options, DIFF_PLAIN);
> + diff_get_color_opt(options, DIFF_PLAIN);
> add_c = diff_get_color_opt(options, DIFF_FILE_NEW);
> del_c = diff_get_color_opt(options, DIFF_FILE_OLD);
diff_get_color_opt() has no side-effects; the changed line is a no-op.
René
next prev parent reply other threads:[~2009-09-26 19:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 14:46 [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer Giuseppe Scrivano
2009-09-26 15:58 ` Johannes Schindelin
2009-09-26 18:21 ` Giuseppe Scrivano
2009-09-26 18:34 ` Sverre Rabbelier
2009-09-26 18:46 ` Giuseppe Scrivano
2009-09-26 19:15 ` Giuseppe Scrivano
2009-09-26 19:28 ` René Scharfe [this message]
2009-09-26 20:39 ` Johannes Schindelin
2009-09-26 20:46 ` Jeff King
2009-09-26 21:03 ` Reece Dunn
2009-09-26 21:12 ` Jeff King
2009-09-26 21:20 ` Reece Dunn
2009-09-26 21:36 ` Jeff King
2009-09-26 21:46 ` Reece Dunn
2009-09-26 21:42 ` Giuseppe Scrivano
2009-09-27 0:41 ` Nicolas Pitre
2009-09-27 8:21 ` Giuseppe Scrivano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABE6B6A.4000400@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gscrivano@gnu.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).