From: Marius Storm-Olsen <mstormo@gmail.com>
To: Michael Wookey <michaelwookey@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's
Date: Mon, 28 Sep 2009 12:21:57 +0200 [thread overview]
Message-ID: <4AC08E45.8010707@gmail.com> (raw)
In-Reply-To: <d2e97e800909280255h70e4c006m98cde895b95fef29@mail.gmail.com>
Michael Wookey said the following on 28.09.2009 11:55:
>> It seems that the project file that is generated by Vcproj.pm
>> (inadvertently?) defines UNICODE. Perhaps the patch below is better
>> than my original workaround. If you think so, I'll create a formal
>> patch.
>>
>> [ sorry if the patch wraps ]
>>
>
> scrub the previous patch... there were more instances of UNICODE
> defined (for release and debug builds). The patch below takes care of
> them all.
Yup, IMO this is the correct patch, since it will follow the Makefile
more closely. So, if we then decide to add UNICODE in the Makefile,
the generated files will follow.
Make it into a proper patch, and I'll ack.
--
.marius
prev parent reply other threads:[~2009-09-28 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 4:10 [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Michael Wookey
2009-09-22 6:08 ` Johannes Sixt
2009-09-22 7:23 ` Marius Storm-Olsen
2009-09-22 9:17 ` Michael Wookey
2009-09-22 9:40 ` Marius Storm-Olsen
2009-09-22 9:54 ` Michael Wookey
2009-09-23 4:43 ` Michael Wookey
2009-09-28 6:45 ` Johannes Sixt
2009-09-28 7:47 ` Michael Wookey
2009-09-28 8:10 ` Johannes Sixt
2009-09-28 9:50 ` Michael Wookey
2009-09-28 9:55 ` Michael Wookey
2009-09-28 10:21 ` Marius Storm-Olsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC08E45.8010707@gmail.com \
--to=mstormo@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=michaelwookey@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).