From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Storm-Olsen Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Date: Mon, 28 Sep 2009 12:21:57 +0200 Message-ID: <4AC08E45.8010707@gmail.com> References: <4AB869EE.1020200@viscovery.net> <4AB87B6B.1070808@gmail.com> <4AB89B7F.3050902@gmail.com> <4AC05BA5.4050106@viscovery.net> <4AC06F65.1020301@viscovery.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Johannes Sixt , git@vger.kernel.org, "Shawn O. Pearce" To: Michael Wookey X-From: git-owner@vger.kernel.org Mon Sep 28 12:22:44 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MsDN2-0002SQ-A5 for gcvg-git-2@lo.gmane.org; Mon, 28 Sep 2009 12:22:16 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbZI1KWF (ORCPT ); Mon, 28 Sep 2009 06:22:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbZI1KWF (ORCPT ); Mon, 28 Sep 2009 06:22:05 -0400 Received: from ey-out-2122.google.com ([74.125.78.25]:16297 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbZI1KWD (ORCPT ); Mon, 28 Sep 2009 06:22:03 -0400 Received: by ey-out-2122.google.com with SMTP id 4so46312eyf.19 for ; Mon, 28 Sep 2009 03:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=ufbe3Dwlpnskd7/OlBevozF8os3hoeSArGIIA30QNtU=; b=Of9gkgWdH7qWR7cpOt3mtyVunFFCkIGNaPoPeznymcDd6j3kuW020wN0hR2VwDsw/S QMt3nD+e++VpBXeqcY16BcmfLcTxvrGP9oXxhPNoOIrKLW/mmDdub3Q5sPKV/xfm9x8T x61CAVO7C6TMtps5dwnIlJIfww1nu8UIOTI2E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=kJHFNb/749/vodRF3p076Oo/riPajS53jkTMX+NqNIeQnlaGFHY7RhNzYBrvjn0wAn BTwJ5ACl+sMMjlv/HmEOHKmVYiLbP8PXsH9Yp7OkqOd+wCBYOW+6VPk0DX4k/DWeytmr lnBXxCJH0znv+64SN+Ahnsx/6x4z9Fs3iTxAY= Received: by 10.210.96.23 with SMTP id t23mr2928384ebb.11.1254133326924; Mon, 28 Sep 2009 03:22:06 -0700 (PDT) Received: from ?172.24.90.95? ([62.70.27.104]) by mx.google.com with ESMTPS id 10sm136101eyd.21.2009.09.28.03.22.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 28 Sep 2009 03:22:06 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Lightning/0.9 Thunderbird/2.0.0.23 ThunderGit/0.1a Mnenhy/0.7.6.666 In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Michael Wookey said the following on 28.09.2009 11:55: >> It seems that the project file that is generated by Vcproj.pm >> (inadvertently?) defines UNICODE. Perhaps the patch below is better >> than my original workaround. If you think so, I'll create a formal >> patch. >> >> [ sorry if the patch wraps ] >> > > scrub the previous patch... there were more instances of UNICODE > defined (for release and debug builds). The patch below takes care of > them all. Yup, IMO this is the correct patch, since it will follow the Makefile more closely. So, if we then decide to add UNICODE in the Makefile, the generated files will follow. Make it into a proper patch, and I'll ack. -- .marius