git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Pipping <webmaster@hartwork.org>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>,
	Robert Buchholz <rbu@gentoo.org>
Subject: Re: gitweb atom feeds broken (on repo.or.cz only?)
Date: Mon, 28 Sep 2009 16:44:14 +0200	[thread overview]
Message-ID: <4AC0CBBE.7020603@hartwork.org> (raw)
In-Reply-To: <be6fef0d0909280023x46522d91oc786feef23cb226a@mail.gmail.com>

Tay Ray Chuan wrote:
>> i noticed that the atom feeds generated by repo.or.cz's gitweb (e.g.
>> [1]) show no content in firefox 3.5.2.  this seems to be due to invalid
>> xml in it as shown by running [1] through feedvalidator, results at [2].
> 
> it's a case of a misspelled tag. In the <author> tag <B> is closed by a </b>.

It's actually a bit more, I just checked against the Relax NG schema of
Atom v11 from RFC 4287.

Neither <span> nor <b>/<B> are allowed inside <name>, and the '\n' isn't
either.  This is what we get:

=============================================================================
<author><name>&#x61;&#x6E;drea<!-- @
-->&#64;dot&#x74;out<span><B>&#46;</b></span>com</name></author>\n<icon>/git-favicon.png</icon>
=============================================================================


This would be valid:

=============================================================================
<author>
  <name>and&#x72;ea<!-- @ -->&#64;&#x64;ottout&#46;com</name>
</author>
<icon>/git-favicon.png</icon>
=============================================================================


Petr, is the e-mail crippling a repo.or.cz-only thing?



Sebastian

  reply	other threads:[~2009-09-28 14:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27 17:35 gitweb atom feeds broken (on repo.or.cz only?) Sebastian Pipping
2009-09-28  7:23 ` Tay Ray Chuan
2009-09-28 14:44   ` Sebastian Pipping [this message]
2009-10-13 12:14     ` Sebastian Pipping
2009-10-14 14:17       ` Petr Baudis
2009-10-14 14:35         ` Sebastian Pipping
2009-10-14 14:40           ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC0CBBE.7020603@hartwork.org \
    --to=webmaster@hartwork.org \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=rbu@gentoo.org \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).