git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marius Storm-Olsen <marius@storm-olsen.com>
To: Erik Faye-Lund <kusmabite@googlemail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto
Date: Sat, 03 Oct 2009 22:08:56 +0200	[thread overview]
Message-ID: <4AC7AF58.1090603@gmail.com> (raw)
In-Reply-To: <40aa078e0910031305u38cfaf4aua72d4c7af2a470b2@mail.gmail.com>


Erik Faye-Lund said the following on 03.10.2009 22:05:
> On Sat, Oct 3, 2009 at 1:00 PM, Marius Storm-Olsen <mstormo@gmail.com> wrote:
>>  This patch was actually sent using the MSVC
>>  git-imap-send.exe to my GMail account.
>>   D:\msvc\git>cat
>> 0001-MSVC-Enable-OpenSSL-and-translate-lcrypto.patch |
>> git-imap-send.exe
>>   Resolving imap.gmail.com... ok
>>   Connecting to 74.125.79.109:993... ok
>>   Logging in...
>>   sending 1 message
>>   100% (1/1) done
>>  :)
> 
> Awesome :)

Yup, only sad to see that GMail dropped the In-reply-to when sending :-/

>> diff --git a/Makefile b/Makefile
>> index 8818f0f..c4b91d8 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -881,7 +881,6 @@ ifdef MSVC
>>        GIT_VERSION := $(GIT_VERSION).MSVC
>>        pathsep = ;
>>        NO_PREAD = YesPlease
>> -       NO_OPENSSL = YesPlease
>>        NO_LIBGEN_H = YesPlease
>>        NO_SYMLINK_HEAD = YesPlease
>>        NO_IPV6 = YesPlease
> 
> Didn't my 7/7 already do this hunk?

Not for MSVC. It has it's own section above the MinGW part. Besides, the
-lcrypto 'translation' is critical for it to link.

--
.marius

  reply	other threads:[~2009-10-03 20:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-03 20:00 [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto Marius Storm-Olsen
2009-10-03 20:05 ` Erik Faye-Lund
2009-10-03 20:08   ` Marius Storm-Olsen [this message]
2009-10-03 20:17     ` Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC7AF58.1090603@gmail.com \
    --to=marius@storm-olsen.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@googlemail.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).