git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* A bug or a feature (git diff --author + --grep)
@ 2009-10-04 10:25 Pascal Obry
  2009-10-04 13:19 ` Björn Steinbrink
  0 siblings, 1 reply; 3+ messages in thread
From: Pascal Obry @ 2009-10-04 10:25 UTC (permalink / raw)
  To: git list


I would have expected the --author and --grep option to work as pipeline 
filters. The first on the command line being applied first.

In other word I would have expected:

    --author AND --grep

But it turn out that the result are maching either --author or --grep:

    --author OR --grep

For example on the Git project:

    $ git log --author=obry --grep=Cygwin

Returns commit from obry and commit having Cygwin in their log.

Is this a bug or a feature?

Thanks,
Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: A bug or a feature (git diff --author + --grep)
  2009-10-04 10:25 A bug or a feature (git diff --author + --grep) Pascal Obry
@ 2009-10-04 13:19 ` Björn Steinbrink
  2009-10-04 13:44   ` Pascal Obry
  0 siblings, 1 reply; 3+ messages in thread
From: Björn Steinbrink @ 2009-10-04 13:19 UTC (permalink / raw)
  To: Pascal Obry; +Cc: git list

On 2009.10.04 12:25:59 +0200, Pascal Obry wrote:
> 
> I would have expected the --author and --grep option to work as
> pipeline filters. The first on the command line being applied first.
> 
> In other word I would have expected:
> 
>    --author AND --grep
> 
> But it turn out that the result are maching either --author or --grep:
> 
>    --author OR --grep
> 
> For example on the Git project:
> 
>    $ git log --author=obry --grep=Cygwin
> 
> Returns commit from obry and commit having Cygwin in their log.
> 
> Is this a bug or a feature?

Feature. There's --all-match to switch on AND-mode.

Björn

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: A bug or a feature (git diff --author + --grep)
  2009-10-04 13:19 ` Björn Steinbrink
@ 2009-10-04 13:44   ` Pascal Obry
  0 siblings, 0 replies; 3+ messages in thread
From: Pascal Obry @ 2009-10-04 13:44 UTC (permalink / raw)
  To: Björn Steinbrink; +Cc: git list

Björn,

> Feature. There's --all-match to switch on AND-mode.

Thanks for the quick answer, I missed the --all-macth option.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-10-04 13:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-04 10:25 A bug or a feature (git diff --author + --grep) Pascal Obry
2009-10-04 13:19 ` Björn Steinbrink
2009-10-04 13:44   ` Pascal Obry

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).