git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: "Björn Gustavsson" <bgustavsson@gmail.com>
Cc: Stephen Boyd <bebarino@gmail.com>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Teach 'rebase -i' the command "reword"
Date: Tue, 06 Oct 2009 09:23:41 +0200	[thread overview]
Message-ID: <4ACAF07D.2030604@viscovery.net> (raw)
In-Reply-To: <4ACAEBBA.9000806@gmail.com>

Björn Gustavsson schrieb:
> @@ -368,17 +368,17 @@ By replacing the command "pick" with the command "edit", you can tell
>  the files and/or the commit message, amend the commit, and continue
>  rebasing.
>  
> -If you just want to edit the commit message for a commit, you can replace
> -the command "pick" with the command "reword".
> +If you just want to edit the commit message for a commit, replace the
> +command "pick" with the command "reword".
>  
>  If you want to fold two or more commits into one, replace the command
>  "pick" with "squash" for the second and subsequent commit.  If the
>  commits had different authors, it will attribute the squashed commit to
>  the author of the first commit.
>  
> -In both cases, or when a "pick" does not succeed (because of merge
> -errors), the loop will stop to let you fix things, and you can continue
> -the loop with `git rebase --continue`.
> +When "pick" has been replaced with "edit" or when a "pick" does not
> +succeed (because of merge errors), the loop will stop to let you fix
> +things, and you can continue the loop with `git rebase --continue`.

Since "reword" is "pick" + editor, it can fail due to conflicts as well.
Perhaps:

'git-rebase' will stop after an edit command or when a command failed
(due to merge errors). When you are done with your edits or with resolving
merge conflicts, continue with `git rebase --continue`.

(I'm unsure about the mark-up.)

-- Hannes

  reply	other threads:[~2009-10-06  7:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 16:16 [PATCH] Teach 'rebase -i' the command "reword" Björn Gustavsson
2009-10-05 20:38 ` Johannes Schindelin
2009-10-06  2:09 ` Sebastian Pipping
2009-10-06  2:34 ` Stephen Boyd
2009-10-06  7:03   ` Björn Gustavsson
2009-10-06  7:23     ` Johannes Sixt [this message]
2009-10-06  7:43     ` Stephen Boyd
2009-10-06  8:25       ` Björn Gustavsson
  -- strict thread matches above, loose matches on Subject: below --
2009-10-07  6:13 Björn Gustavsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACAF07D.2030604@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=bebarino@gmail.com \
    --cc=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).