From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH 1/3] completion: fix alias listings with newlines Date: Thu, 08 Oct 2009 10:10:53 +0200 Message-ID: <4ACD9E8D.1070702@viscovery.net> References: <1254905331-29516-1-git-send-email-bebarino@gmail.com> <4ACC6055.1070204@viscovery.net> <4ACCE417.5080907@gmail.com> <20091008042917.GX9261@spearce.org> <4ACD961D.9080401@gmail.com> <4ACD9ABC.4070809@viscovery.net> <4ACD9C66.1080308@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Shawn O. Pearce" , Junio C Hamano , git@vger.kernel.org To: Stephen Boyd X-From: git-owner@vger.kernel.org Thu Oct 08 10:14:39 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mvo90-0006xA-TK for gcvg-git-2@lo.gmane.org; Thu, 08 Oct 2009 10:14:39 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755065AbZJHILc (ORCPT ); Thu, 8 Oct 2009 04:11:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754845AbZJHILc (ORCPT ); Thu, 8 Oct 2009 04:11:32 -0400 Received: from lilzmailso02.liwest.at ([212.33.55.13]:48650 "EHLO lilzmailso02.liwest.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbZJHILb (ORCPT ); Thu, 8 Oct 2009 04:11:31 -0400 Received: from cpe228-254.liwest.at ([81.10.228.254] helo=linz.eudaptics.com) by lilzmailso02.liwest.at with esmtpa (Exim 4.69) (envelope-from ) id 1Mvo5N-0007WG-DN; Thu, 08 Oct 2009 10:10:53 +0200 Received: from [127.0.0.1] (J6T.linz.viscovery [192.168.1.95]) by linz.eudaptics.com (Postfix) with ESMTP id 3371D4E9; Thu, 8 Oct 2009 10:10:53 +0200 (CEST) User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) In-Reply-To: <4ACD9C66.1080308@gmail.com> X-Enigmail-Version: 0.95.5 X-Spam-Score: -1.4 (-) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Stephen Boyd schrieb: > Johannes Sixt wrote: >> OTOH, you can simply revert the hunk from 518ef8f (completion: Replace >> config --list with --get-regexp, 2009-09-11) that applies here, or even >> only reinstate the case statement in the loop body without changing >> anything else. > > I'm not opposed to the idea, but then it wouldn't work with something like > > [alias] > whowhat = "log --format="%an\nalias.broken=foo'" > > although that actually happening is probably rare, it can still happen. I'd ignore this case, but *you* write the patch, *you* get to draw the line ;) -- Hannes