From: Johannes Sixt <j.sixt@viscovery.net>
To: unlisted-recipients:; (no To-header on input)
Cc: msysgit@googlegroups.com, git@vger.kernel.org,
Erik Faye-Lund <kusmabite@gmail.com>,
Marius Storm-Olsen <mstormo@gmail.com>
Subject: Re: [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL
Date: Wed, 21 Oct 2009 14:15:41 +0200 [thread overview]
Message-ID: <4ADEFB6D.9050501@viscovery.net> (raw)
In-Reply-To: <200910192020.44890.j6t@kdbg.org>
Johannes Sixt schrieb:
> On Montag, 19. Oktober 2009, Erik Faye-Lund wrote:
>> Since we have OpenSSL in msysgit now, enable it to support SSL
>> encryption for imap-send.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>
> Acked-by: Johannes Sixt <j6t@kdbg.org>
I seem to have ack'ed this one too early. After testing in my environment,
I get:
imap-send.o: In function `ssl_socket_perror':
D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_get_error'
D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_error_string'
I need this patch in addition, and perhaps something similar is also
needed with MSVC:
diff --git a/Makefile b/Makefile
index c4b91d8..7e6a1c3 100644
--- a/Makefile
+++ b/Makefile
@@ -932,6 +932,7 @@ else
ifneq (,$(findstring MINGW,$(uname_S)))
pathsep = ;
NO_PREAD = YesPlease
+ NEEDS_CRYPTO_WITH_SSL = YesPlease
NO_LIBGEN_H = YesPlease
NO_SYMLINK_HEAD = YesPlease
NO_IPV6 = YesPlease
next prev parent reply other threads:[~2009-10-21 12:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 15:42 [PATCH v4 0/8] imap-send: Windows support Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 1/8] imap-send: remove useless uid code Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 2/8] imap-send: use separate read and write fds Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 3/8] imap-send: use run-command API for tunneling Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 4/8] imap-send: fix compilation-error on Windows Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 5/8] imap-send: build imap-send " Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 6/8] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 7/8] mingw: enable OpenSSL Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 8/8] MSVC: Enable OpenSSL, and translate -lcrypto Erik Faye-Lund
2009-10-19 18:20 ` [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL Johannes Sixt
2009-10-21 12:15 ` Johannes Sixt [this message]
2009-10-21 12:43 ` Erik Faye-Lund
2009-10-21 12:55 ` [msysGit] " Johannes Sixt
2009-10-19 18:20 ` [msysGit] [PATCH v4 6/8] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADEFB6D.9050501@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=mstormo@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).