From: Johannes Sixt <j6t@kdbg.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Scott Chacon <schacon@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] Update packfile transfer protocol documentation
Date: Sat, 31 Oct 2009 21:12:46 +0100 [thread overview]
Message-ID: <4AEC9A3E.7030601@kdbg.org> (raw)
In-Reply-To: <20091031020634.GL10505@spearce.org>
Shawn O. Pearce schrieb:
> Scott Chacon <schacon@gmail.com> wrote:
>> +Currently only 'host' is allowed in the extra information. It's
>
> No. We should make this a MUST. As in:
>
> Only host-parameter is allowed in the git-proto-request.
> Clients MUST NOT attempt to send additional parameters.
>
> Sending another header can cause older git-daemons to lock up.
I think you are making a wrong case here: Older git-daemons that lock up
are security holes because they allow DoS attacks, and any decent admin
will want to upgrade to a fixed git-daemon anyway.
Fixed git-daemons can allow extra information in addition to 'host'. I
know you argued otherwise when you submitted the fix to git-daemon, but I
think you were wrong already back then.
-- Hannes
next prev parent reply other threads:[~2009-10-31 20:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 17:35 [PATCH] Update packfile transfer protocol documentation Scott Chacon
2009-10-30 22:07 ` Junio C Hamano
2009-10-31 2:06 ` Shawn O. Pearce
2009-10-31 20:12 ` Johannes Sixt [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-01 23:18 Scott Chacon
2009-11-02 5:17 ` Junio C Hamano
2009-11-02 15:41 ` Shawn O. Pearce
2009-11-02 17:31 ` Junio C Hamano
2009-11-02 15:43 ` Shawn O. Pearce
2009-11-02 23:48 ` Junio C Hamano
2009-11-02 23:57 ` Shawn O. Pearce
2009-11-03 0:36 ` Junio C Hamano
2009-11-03 0:58 ` Shawn O. Pearce
2009-11-03 22:05 ` Scott Chacon
2009-11-04 0:40 ` Junio C Hamano
2009-11-04 0:40 ` Junio C Hamano
2009-11-04 0:56 ` Shawn O. Pearce
2009-11-04 1:07 ` Junio C Hamano
2009-11-04 1:18 ` Shawn O. Pearce
2009-11-04 1:48 ` Junio C Hamano
2009-11-04 5:58 Scott Chacon
2009-11-04 6:36 ` Sverre Rabbelier
2009-11-05 5:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEC9A3E.7030601@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=schacon@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).