git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "Björn Gustavsson" <bgustavsson@gmail.com>
Subject: Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat
Date: Tue, 03 Nov 2009 23:35:33 -0800	[thread overview]
Message-ID: <4AF12EC5.4030407@gmail.com> (raw)
In-Reply-To: <20091104071940.GA15011@coredump.intra.peff.net>

Jeff King wrote:
>
> This patch unbreaks what 68daa64 did (while still preserving
> what 68daa64 was trying to do), reinstating "-p" to suppress
> the default behavior. We do this by parsing "-p" ourselves
> in format-patch, and noting whether it was used explicitly.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>   

This looks good to me; covering 2 and 3 of Junio's TODO list.

> @@ -940,6 +941,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  		{ OPTION_CALLBACK, 0, "thread", &thread, "style",
>  			    "enable message threading, styles: shallow, deep",
>  			    PARSE_OPT_OPTARG, thread_callback },
> +		OPT_BOOLEAN('p', NULL, &use_patch_format,
> +			"show patch format instead of default (patch + stat)"),
>  		OPT_END()
>  	};

I don't imagine we want this option in the messaging group though. Can 
you move it up?

  reply	other threads:[~2009-11-04  7:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 21:24 [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat Stephen Boyd
2009-11-04  5:49 ` Junio C Hamano
2009-11-04  6:36   ` Jeff King
2009-11-04  7:10     ` Jeff King
2009-11-04  7:19       ` Jeff King
2009-11-04  7:35         ` Stephen Boyd [this message]
2009-11-04  7:37           ` Jeff King
2009-11-04 18:10             ` Junio C Hamano
2009-11-04  7:49       ` Björn Gustavsson
2009-11-04  7:26     ` Junio C Hamano
2009-11-04  7:00   ` Björn Gustavsson
2009-11-04  7:31     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF12EC5.4030407@gmail.com \
    --to=bebarino@gmail.com \
    --cc=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).