From: Johannes Sixt <j.sixt@viscovery.net>
To: "Andrzej K. Haczewski" <ahaczewski@gmail.com>
Cc: git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
kusmabite@gmail.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Paolo Bonzini <bonzini@gnu.org>
Subject: Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API
Date: Thu, 05 Nov 2009 18:31:41 +0100 [thread overview]
Message-ID: <4AF30BFD.4070101@viscovery.net> (raw)
In-Reply-To: <1257439548-9258-1-git-send-email-ahaczewski@gmail.com>
Thanks.
I pushed this to
git://repo.or.cz/git/mingw/j6t.git pthreads-for-windows
together with Nico's patch and another patch to enable pthreads on
MinGW unconditionally. Feedback welcome!
Andrzej K. Haczewski (1):
MSVC: Windows-native implementation for subset of Pthreads API
Johannes Sixt (1):
MinGW: enable pthreads
Nicolas Pitre (1):
pack-objects: move thread autodetection closer to relevant code
This is my patch:
--- >8 ---
From: Johannes Sixt <j6t@kdbg.org>
Subject: [PATCH] MinGW: enable pthreads
If the MinGW build was built as part of the msysgit build environment,
then threading was already enabled because the pthreads package from
GNU-Win32 is available in msysgit.
The previous patch added a minimal pthreads implementation for Windows.
Therefore, we can now enable code that uses pthreads unconditionally.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index db7ffb0..4b8603a 100644
--- a/Makefile
+++ b/Makefile
@@ -986,9 +986,11 @@ ifneq (,$(findstring MINGW,$(uname_S)))
UNRELIABLE_FSTAT = UnfortunatelyYes
OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
NO_REGEX = YesPlease
+ THREADED_DELTA_SEARCH = YesPlease
COMPAT_CFLAGS += -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/fnmatch
COMPAT_CFLAGS += -DSTRIP_EXTENSION=\".exe\"
- COMPAT_OBJS += compat/mingw.o compat/fnmatch/fnmatch.o compat/winansi.o
+ COMPAT_OBJS += compat/mingw.o compat/fnmatch/fnmatch.o compat/winansi.o \
+ compat/win32/pthread.o
EXTLIBS += -lws2_32
X = .exe
ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
@@ -998,10 +1000,8 @@ ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
EXTLIBS += /mingw/lib/libz.a
NO_R_TO_GCC_LINKER = YesPlease
INTERNAL_QSORT = YesPlease
- THREADED_DELTA_SEARCH = YesPlease
else
NO_CURL = YesPlease
- NO_PTHREADS = YesPlease
endif
endif
endif
--
1.6.5.2.1198.ge698c
next prev parent reply other threads:[~2009-11-05 17:31 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 21:30 [PATCH 0/1] Port of pthreads to Windows API threads Andrzej K. Haczewski
2009-11-03 21:30 ` [PATCH 1/1] MSVC: port pthread code to native Windows threads Andrzej K. Haczewski
2009-11-03 23:38 ` Johannes Schindelin
2009-11-04 2:34 ` Joshua Jensen
2009-11-04 7:44 ` Andrzej K. Haczewski
2009-11-04 8:24 ` Johannes Sixt
2009-11-04 11:02 ` Johannes Schindelin
2009-11-04 8:17 ` Andrzej K. Haczewski
2009-11-04 8:15 ` Johannes Sixt
2009-11-04 8:48 ` Michael Wookey
2009-11-04 10:53 ` Andrzej K. Haczewski
2009-11-04 10:37 ` [PATCH] " Andrzej K. Haczewski
2009-11-04 10:50 ` Erik Faye-Lund
2009-11-04 10:56 ` Andrzej K. Haczewski
2009-11-04 11:14 ` Paolo Bonzini
2009-11-04 11:23 ` Paolo Bonzini
2009-11-04 12:39 ` Johannes Sixt
2009-11-04 13:47 ` Andrzej K. Haczewski
2009-11-04 14:34 ` Johannes Sixt
2009-11-04 14:50 ` Andrzej K. Haczewski
2009-11-04 20:43 ` Daniel Barkalow
2009-11-04 21:17 ` Nicolas Pitre
2009-11-04 22:22 ` Daniel Barkalow
2009-11-05 0:27 ` Nicolas Pitre
2009-11-05 13:48 ` Dmitry Potapov
2009-11-04 14:14 ` Andrzej K. Haczewski
2009-11-04 14:19 ` Erik Faye-Lund
2009-11-04 14:04 ` Johannes Schindelin
2009-11-04 15:55 ` [PATCH] MSVC: Windows-native implementation for subset of Pthreads API Andrzej K. Haczewski
2009-11-04 18:10 ` Nicolas Pitre
2009-11-04 21:16 ` Andrzej K. Haczewski
2009-11-04 21:32 ` [PATCH] pack-objects: move thread autodetection closer to relevant code Nicolas Pitre
2009-11-06 7:20 ` Junio C Hamano
2009-11-04 21:41 ` [PATCH] MSVC: Windows-native implementation for subset of Pthreads API Erik Faye-Lund
2009-11-04 22:50 ` Andrzej K. Haczewski
2009-11-05 2:47 ` Nicolas Pitre
2009-11-05 9:00 ` Andrzej K. Haczewski
2009-11-05 9:41 ` Erik Faye-Lund
2009-11-05 10:18 ` Andrzej K. Haczewski
2009-11-05 12:27 ` Johannes Sixt
2009-11-05 12:53 ` Andrzej K. Haczewski
2009-11-05 19:25 ` Nicolas Pitre
2009-11-05 20:38 ` Andrzej K. Haczewski
2009-11-05 22:15 ` Nicolas Pitre
2009-11-04 21:52 ` Nicolas Pitre
2009-11-04 23:47 ` Andrzej K. Haczewski
2009-11-04 23:57 ` Andrzej K. Haczewski
2009-11-05 0:22 ` Nicolas Pitre
2009-11-05 8:51 ` Andrzej K. Haczewski
2009-11-05 19:22 ` Nicolas Pitre
2009-11-05 2:10 ` Nicolas Pitre
2009-11-05 8:45 ` Andrzej K. Haczewski
2009-11-05 19:17 ` Nicolas Pitre
2009-11-05 7:33 ` Johannes Sixt
2009-11-04 23:58 ` Junio C Hamano
2009-11-05 16:45 ` Andrzej K. Haczewski
2009-11-05 17:31 ` Johannes Sixt [this message]
2009-11-05 19:39 ` Nicolas Pitre
2009-11-05 20:09 ` Andrzej K. Haczewski
2009-11-05 20:36 ` Nicolas Pitre
2009-11-06 8:10 ` Andrzej K. Haczewski
2009-11-06 8:25 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF30BFD.4070101@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=ahaczewski@gmail.com \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).