From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Marius Storm-Olsen <mstormo@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] Add explicit Cygwin check to guard WIN32 header inclusion
Date: Mon, 09 Nov 2009 19:26:19 +0000 [thread overview]
Message-ID: <4AF86CDB.6030200@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4AF5D6F8.40608@ramsay1.demon.co.uk>
Ramsay Jones wrote:
> diff --git a/git-compat-util.h b/git-compat-util.h
> index ef60803..c4b9e5a 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -65,10 +65,10 @@
> #define _NETBSD_SOURCE 1
> #define _SGI_SOURCE 1
>
> -#ifdef WIN32 /* Both MinGW and MSVC */
> -#define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
> -#include <winsock2.h>
> -#include <windows.h>
> +#if defined(_WIN32) && !defined(__CYGWIN__) /* Both MinGW and MSVC */
> +# define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
> +# include <winsock2.h>
> +# include <windows.h>
Arrgghhh.
Sorry, Junio, I meant to change this before sending it out. :(
I had intended to remove the added indentation (which I don't even remember
doing!), since it obscures the "real change", which simply consists of the
new expression in the #if preprocessor line.
I'll send a new version of this patch.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2009-11-09 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-07 20:22 [PATCH v2 4/4] Add explicit Cygwin check to guard WIN32 header inclusion Ramsay Jones
2009-11-09 7:20 ` Johannes Sixt
2009-11-10 18:48 ` Ramsay Jones
2009-11-09 19:26 ` Ramsay Jones [this message]
2009-11-09 20:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF86CDB.6030200@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox