From: Johannes Sixt <j.sixt@viscovery.net>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Define $PERL_PATH in test-lib.sh
Date: Tue, 10 Nov 2009 13:26:53 +0100 [thread overview]
Message-ID: <4AF95C0D.90605@viscovery.net> (raw)
In-Reply-To: <1257850011-7544-1-git-send-email-book@cpan.org>
Philippe Bruhat (BooK) schrieb:
> diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
> index 64f947d..dc710f8 100755
> --- a/t/t9400-git-cvsserver-server.sh
> +++ b/t/t9400-git-cvsserver-server.sh
> @@ -20,7 +20,7 @@ then
> say 'skipping git-cvsserver tests, cvs not found'
> test_done
> fi
> -perl -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
> +$PERL_PATH -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
Shouldn't this be "$PERL_PATH", i.e., double-quoted? (Ditto in the other
cases that you replaced.)
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index f2ca536..54dd4d5 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -730,6 +730,8 @@ esac
>
> test -z "$NO_PERL" && test_set_prereq PERL
>
> +test -z "$NO_PERL" && test -z "$PERL_PATH" && export PERL_PATH=/usr/bin/perl
Wouldn't
... && export PERL_PATH=perl
be a safer fall-back?
-- Hannes
next prev parent reply other threads:[~2009-11-10 12:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 10:46 [PATCH] Define $PERL_PATH in test-lib.sh Philippe Bruhat (BooK)
2009-11-10 12:23 ` Jeff King
2009-11-10 13:33 ` Philippe Bruhat (BooK)
2009-11-15 9:12 ` Junio C Hamano
2009-11-16 23:48 ` Philippe Bruhat (BooK)
2009-11-16 23:53 ` [PATCH] Make sure $PERL_PATH is defined when the test suite is run Philippe Bruhat (BooK)
2009-11-17 0:10 ` Junio C Hamano
2009-11-17 0:17 ` Philippe Bruhat (BooK)
2009-11-17 0:20 ` Philippe Bruhat (BooK)
2009-11-17 8:30 ` Johannes Sixt
2009-11-17 8:35 ` Philippe Bruhat (BooK)
2009-11-17 18:25 ` Junio C Hamano
2009-11-17 8:42 ` Philippe Bruhat (BooK)
2009-11-10 12:26 ` Johannes Sixt [this message]
2009-11-10 13:34 ` [PATCH] Define $PERL_PATH in test-lib.sh Philippe Bruhat (BooK)
2009-11-10 20:17 ` Junio C Hamano
2009-11-11 8:40 ` Philippe Bruhat (BooK)
2009-11-11 8:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF95C0D.90605@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=book@cpan.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).