From: "J.H." <warthog19@eaglescrag.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sylvain Rabot <sylvain@abstraction.fr>, git <git@vger.kernel.org>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: Make Gitweb behave like Apache mod_userdir
Date: Tue, 17 Nov 2009 14:59:20 -0800 [thread overview]
Message-ID: <4B032AC8.4@eaglescrag.net> (raw)
In-Reply-To: <7vd43gerak.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Sylvain Rabot <sylvain@abstraction.fr> writes:
>
>>> Wouldn't it be a good idea to somehow make this work well together with
>>> the --user-path feature of git-daemon?
>>>
>>> Perhaps the recommended name given in the example shouldn't be ~/gitweb,
>>> but more like ~/public_git, as this is like ~/public_html but for git
>>> repositories. Then the end users will browse
>> As I said, it's configuration :)
>
> Wrong answer.
>
> Exactly because it is configurable, the document that outlines the
> recommended practice should suggest the best convention. My point was
> that it is likely to be tied to "git"-ness of the specified directory
> under $HOME/, not limited to "gitweb"-ness, and it is wrong to recommend a
> name tied to "gitweb"-ness in this document.
For starters I think overriding the /~<user> (specifically the ~ here)
is going to be a bad idea no matter what you do and gives the wrong
impression about what / how the request is being responded to. You
might want to try and pick a different delimiter or re-work the rule so
that you could have something like:
http://git.kernel.org/<gitweb urls>
http://git.kernel.org/user/<gitweb urls>
Your also, likely, going to need to take into account things like
index.cgi and gitweb.cgi in the url as things like:
http://git.kernel.org/?p=bluetooth/bluez-gnome.git;a=summary
http://git.kernel.org/gitweb.cgi?p=bluetooth/bluez-gnome.git;a=summary
are likely to be correct for almost all installations.
I would agree with Junio on this, if your suggesting a possible practice
you should focus on the best convention. Making it depend on something
like ~/gitweb doesn't make it clear or obvious enough to a user, or an
administrator, that the directory is being exported for the world to
see. There is a reason it's called ~/public_html.
Keep in mind most people are going to read the documentation and
copy/paste what they need and not change anything.
- John 'Warthog9' Hawley
next prev parent reply other threads:[~2009-11-17 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 10:04 Make Gitweb behave like Apache mod_userdir Sylvain Rabot
2009-11-15 21:03 ` Junio C Hamano
2009-11-17 13:58 ` Jakub Narebski
2009-11-17 15:51 ` Sylvain Rabot
2009-11-17 18:12 ` Jakub Narebski
2009-11-17 19:56 ` Sylvain Rabot
2009-11-17 20:15 ` Junio C Hamano
2009-11-17 20:24 ` Sylvain Rabot
2009-11-17 22:10 ` Junio C Hamano
2009-11-17 22:54 ` Sylvain Rabot
2009-11-17 23:40 ` Junio C Hamano
2009-11-17 23:52 ` J.H.
2009-11-17 22:59 ` J.H. [this message]
2009-11-17 23:46 ` Junio C Hamano
2009-11-17 23:59 ` J.H.
2009-11-18 0:14 ` Junio C Hamano
2009-11-18 0:00 ` J.H.
2009-11-18 0:16 ` Sylvain Rabot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B032AC8.4@eaglescrag.net \
--to=warthog19@eaglescrag.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=sylvain@abstraction.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).