From: Michael J Gruber <git@drmicha.warpmail.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH 2/2] status -s: obey color.status
Date: Thu, 26 Nov 2009 17:03:43 +0100 [thread overview]
Message-ID: <4B0EA6DF.6070701@drmicha.warpmail.net> (raw)
In-Reply-To: <4B0EA06A.1050101@viscovery.net>
Johannes Sixt venit, vidit, dixit 26.11.2009 16:36:
> Michael J Gruber schrieb:
>> * Is there any policy regarding use of putchar/puts vs. printf?
>
> If the printed string contains color escapes that should be obeyed, you
> can use only fputs, printf, and fprintf. You should not use puts or putchar.
Oh, I don't use them with colors. I use only color_fprintf for that. I
was wondering whether there's a preference of printf("%c", c) over
putchar(c), for example.
>> * Even if I were to write tests for status -s: How do I test colors?
>
> See t4034-diff-words.sh.
Thanks, I'll keep that in mind for the case that I do have to write test ;)
Michael
next prev parent reply other threads:[~2009-11-26 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 15:24 [RFC/PATCH 0/2] status -s: Use the same config as status Michael J Gruber
2009-11-26 15:24 ` [RFC/PATCH 1/2] status -s: respect the status.relativePaths option Michael J Gruber
2009-11-27 3:15 ` Junio C Hamano
2009-11-27 7:05 ` Jeff King
2009-11-26 15:24 ` [RFC/PATCH 2/2] status -s: obey color.status Michael J Gruber
2009-11-26 15:36 ` Johannes Sixt
2009-11-26 16:03 ` Michael J Gruber [this message]
2009-11-26 19:00 ` Junio C Hamano
2009-11-27 7:00 ` [PATCH] Add a notice that only certain functions can print color escape codes Johannes Sixt
2009-11-27 7:30 ` Junio C Hamano
2009-11-27 7:42 ` Johannes Sixt
2009-11-27 9:22 ` Michael J Gruber
2009-11-27 5:15 ` [RFC/PATCH 2/2] status -s: obey color.status Junio C Hamano
2009-11-27 9:17 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0EA6DF.6070701@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).