From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: [PATCH] Add a notice that only certain functions can print color escape codes Date: Fri, 27 Nov 2009 08:00:01 +0100 Message-ID: <4B0F78F1.4040101@viscovery.net> References: <26d0a2022638ad7b75268ca291b8d02a22f1f66c.1259248243.git.git@drmicha.warpmail.net> <4B0EA06A.1050101@viscovery.net> <7vy6lt6rh3.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Michael J Gruber , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Nov 27 08:00:15 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1NDuoR-0004wf-EM for gcvg-git-2@lo.gmane.org; Fri, 27 Nov 2009 08:00:15 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbZK0HAB (ORCPT ); Fri, 27 Nov 2009 02:00:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753438AbZK0HAB (ORCPT ); Fri, 27 Nov 2009 02:00:01 -0500 Received: from lilzmailso01.liwest.at ([212.33.55.23]:8864 "EHLO lilzmailso02.liwest.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753411AbZK0HAA (ORCPT ); Fri, 27 Nov 2009 02:00:00 -0500 Received: from cpe228-254.liwest.at ([81.10.228.254] helo=theia.linz.viscovery) by lilzmailso02.liwest.at with esmtpa (Exim 4.69) (envelope-from ) id 1NDuoE-0004s0-BE; Fri, 27 Nov 2009 08:00:02 +0100 Received: from [127.0.0.1] (J6T.linz.viscovery [192.168.1.95]) by theia.linz.viscovery (Postfix) with ESMTP id 1C1B61660F; Fri, 27 Nov 2009 08:00:02 +0100 (CET) User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) In-Reply-To: <7vy6lt6rh3.fsf@alter.siamese.dyndns.org> X-Enigmail-Version: 0.95.5 X-Spam-Score: -1.4 (-) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: From: Johannes Sixt We emulate color escape codes on Windows by overriding printf, fprintf, and fputs. Warn users that these are the only functions that can be used to print them. Signed-off-by: Johannes Sixt --- Junio C Hamano schrieb: > Johannes Sixt writes: > >> Michael J Gruber schrieb: >>> * Is there any policy regarding use of putchar/puts vs. printf? >> If the printed string contains color escapes that should be obeyed, you >> can use only fputs, printf, and fprintf. You should not use puts or putchar. > > This msysgit-imposed restriction is something even I do not remember > offhand. Could you please document it somewhere in a file any developer > would get by checking out the 'master' branch of git.git? Like this? color.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/color.h b/color.h index 7d8da6f..edeaa3e 100644 --- a/color.h +++ b/color.h @@ -4,6 +4,11 @@ /* "\033[1;38;5;2xx;48;5;2xxm\0" is 23 bytes */ #define COLOR_MAXLEN 24 +/* + * IMPORTANT: Due to the way these color codes are emulated on Windows, + * write them only using printf, fprintf, and fputs. In particular, + * do not use puts. + */ #define GIT_COLOR_NORMAL "" #define GIT_COLOR_RESET "\033[m" #define GIT_COLOR_BOLD "\033[1m" -- 1.6.6.rc0.43.g50037