From: Johannes Sixt <j.sixt@viscovery.net>
To: kusmabite@gmail.com
Cc: Junio C Hamano <gitster@pobox.com>,
msysgit@googlegroups.com, git@vger.kernel.org,
dotzenlabs@gmail.com, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf()
Date: Fri, 27 Nov 2009 08:09:40 +0100 [thread overview]
Message-ID: <4B0F7B34.4090908@viscovery.net> (raw)
In-Reply-To: <40aa078e0911261537r40b19dffqf019848dcad23fef@mail.gmail.com>
Erik Faye-Lund schrieb:
> Perhaps I can do one better: use memcpy instead of standard
> assignment. The Autoconf manual[1] suggests that it's more portable.
> Something like this:
>
> #ifndef va_copy
> # ifdef __va_copy
> # define va_copy(a,b) __va_copy(a,b)
> # else
> # define va_copy(a,b) memcpy(&a, &b, sizeof (va_list))
> # endif
> #endif
>
> I'll add this to git-compat-util.h this for the next round unless
> someone yells really loud at me.
As I said elsewhere in the thread, I do not see enough reason to add
strbuf_vaddf() only for a syslog() emulation in the first place.
-- Hannes
next prev parent reply other threads:[~2009-11-27 7:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 0:44 [PATCH/RFC 00/11] daemon-win32 Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 03/11] mingw: implement syslog Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 05/11] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 07/11] run-command: support input-fd Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 08/11] daemon: use explicit file descriptor Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 09/11] daemon: use run-command api for async serving Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 10/11] daemon: use full buffered mode for stderr Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 11/11] mingw: compile git-daemon Erik Faye-Lund
2009-11-27 21:17 ` [msysGit] " Johannes Sixt
2009-11-27 20:59 ` [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving Johannes Sixt
2009-12-02 15:45 ` Erik Faye-Lund
2009-12-02 19:12 ` Johannes Sixt
2009-12-08 13:36 ` Erik Faye-Lund
2009-11-26 22:03 ` [msysGit] [PATCH/RFC 08/11] daemon: use explicit file descriptor Johannes Sixt
2009-11-27 14:23 ` Erik Faye-Lund
2009-11-27 15:46 ` Erik Faye-Lund
2009-11-27 20:23 ` Johannes Sixt
2009-11-27 20:28 ` Johannes Sixt
2009-12-08 13:38 ` Erik Faye-Lund
2009-11-26 21:53 ` [msysGit] [PATCH/RFC 07/11] run-command: support input-fd Johannes Sixt
2009-11-27 14:39 ` Erik Faye-Lund
2009-11-27 20:14 ` Johannes Sixt
2009-12-08 13:46 ` Erik Faye-Lund
2009-11-26 21:46 ` [msysGit] [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Johannes Sixt
2009-11-27 16:04 ` Erik Faye-Lund
2009-11-27 19:59 ` Johannes Sixt
2009-12-02 15:57 ` Erik Faye-Lund
2009-12-02 19:27 ` Johannes Sixt
2010-01-09 0:49 ` Erik Faye-Lund
2010-01-10 17:06 ` Erik Faye-Lund
2009-11-26 21:23 ` [msysGit] [PATCH/RFC 03/11] mingw: implement syslog Johannes Sixt
2009-11-27 8:09 ` Erik Faye-Lund
2009-11-27 19:23 ` Johannes Sixt
2009-12-08 14:01 ` Erik Faye-Lund
2009-11-26 0:59 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Junio C Hamano
2009-11-26 10:38 ` Erik Faye-Lund
2009-11-26 11:13 ` Paolo Bonzini
2009-11-26 18:46 ` Junio C Hamano
2009-11-26 23:37 ` Erik Faye-Lund
2009-11-27 7:09 ` Johannes Sixt [this message]
2009-11-26 8:24 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Martin Storsjö
2009-11-26 10:43 ` [PATCH] Improve the mingw getaddrinfo stub to handle more use cases Martin Storsjö
2009-11-26 10:46 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 11:03 ` Martin Storsjö
2009-12-02 13:01 ` Erik Faye-Lund
2009-12-02 13:21 ` Martin Storsjö
2009-12-02 13:49 ` Erik Faye-Lund
2009-12-02 15:11 ` Erik Faye-Lund
2009-12-02 19:34 ` Johannes Sixt
2009-11-26 20:04 ` [msysGit] [PATCH/RFC 00/11] daemon-win32 Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 0:39 Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0F7B34.4090908@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=dotzenlabs@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).