git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ismael Luceno <ismael.luceno@gmail.com>
To: Daniele Segato <daniele.bilug@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git am and CRLF files
Date: Mon, 30 Nov 2009 10:50:51 -0200	[thread overview]
Message-ID: <4B13BFAB.3050002@gmail.com> (raw)
In-Reply-To: <9accb4400911300406l592306c8t889c28ba7b48674b@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

Daniele Segato escribió:
> On Mon, Nov 16, 2009 at 12:43 PM, Erik Faye-Lund
> <kusmabite@googlemail.com> wrote:
>> According to RFC 5322, email messages use CRLF as the
>> newline-sequence. In order to be able to distinguish between CRLF and
>> LF in an e-mail patch, the message needs to be use some
>> transfer-encoding that preserves newline style (like base64).
>>
>> Perhaps this would be better fixed by having format-patch (or prehaps
>> the MUA ?) base64-encode the message body if the file contains
>> non-LF-newlines, and normalizing CRLF to LF before transport-decoding?
>> Or does some MUAs transport-decode before storing the message to disk?
>>
>> I realize this might make it a bit tricky to review patches that
>> contains CRLF-newlines before mailing them out, but perhaps inspecting
>> the format-patch output is the wrong place to do this?
> 
> 
> why don't adding that information in the mail header?
> or may be made format-patch create a "comment line" with that information?
> 
> if that line is missing it could keep the default behavior (what it
> did until now)
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

It would make more sense to simply use MIME attachments...

-- 
Ismael Luceno


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2009-11-30 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  9:44 git am and CRLF files Stefan Naewe
2009-11-16  7:33 ` Stefan Naewe
2009-11-16 10:50   ` Nanako Shiraishi
2009-11-16 11:15     ` Stefan Naewe
2009-11-16 11:43     ` Erik Faye-Lund
2009-11-30 12:06       ` Daniele Segato
2009-11-30 12:50         ` Ismael Luceno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B13BFAB.3050002@gmail.com \
    --to=ismael.luceno@gmail.com \
    --cc=daniele.bilug@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).