From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Marius Storm-Olsen <mstormo@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC PATCH 2/2] MSVC: Fix an "incompatible pointer types" compiler warning
Date: Fri, 04 Dec 2009 22:58:13 +0000 [thread overview]
Message-ID: <4B199405.8040607@ramsay1.demon.co.uk> (raw)
In-Reply-To: <alpine.DEB.1.00.0912041144470.4985@pacific.mpi-cbg.de>
Johannes Schindelin wrote:
> On Thu, 3 Dec 2009, Ramsay Jones wrote:
>
>> compat/mingw.h | 27 ++++++++++++++++++++++++++-
>> compat/msvc.h | 25 +------------------------
>> 2 files changed, 27 insertions(+), 25 deletions(-)
>
> I'd prefer to have the MSVC-specific definitions in msvc.h, along with a
> definition of, say, ALREADY_DEFINED_STATI64 or some such (which tells
> mingw.h not to do anything about those types). There is no need to
> clutter mingw.h with stuff for MSVC.
Ah, yeah, I did think about this. As I said, the original patch was much
simpler and I thought the change to mingw.h was just this side of being
objectionable ;-) However, as the patch continued to gain weight I should
have re-evaluated that... my bad.
New version of the patch coming soon.
ATB,
Ramsay Jones
prev parent reply other threads:[~2009-12-04 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 18:44 [RFC PATCH 2/2] MSVC: Fix an "incompatible pointer types" compiler warning Ramsay Jones
2009-12-04 7:44 ` Johannes Sixt
2009-12-04 22:50 ` Ramsay Jones
2009-12-04 10:47 ` Johannes Schindelin
2009-12-04 22:58 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B199405.8040607@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).