From: David Reiss <dreiss@facebook.com>
To: <git@vger.kernel.org>
Subject: git fast-import not verifying commit author lines?
Date: Mon, 21 Dec 2009 20:22:31 -0800 [thread overview]
Message-ID: <4B304987.7030201@facebook.com> (raw)
mtn git_export produces this output on a simple repo:
blob
mark :1
data 8
content
commit refs/heads/com.example.badexport
mark :2
author <somename> 1261454209 +0000
committer <somename> 1261454209 +0000
data 8
acommit
M 100644 :1 "afile"
progress revision 9b0e11e4d66eba8a3cf26095fb573116b886cd37 (1/1)
#############################################################
The author and committer lines are missing the names (I've filed this as a
bug with monotone). git commit-tree refuses to to produce a commit object
like this, so it seems like git fast-import should detect and report this
instead of silently writing the invalid commit object to the repository.
--David
next reply other threads:[~2009-12-22 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 4:22 David Reiss [this message]
2009-12-22 15:06 ` git fast-import not verifying commit author lines? Shawn O. Pearce
2009-12-30 6:04 ` David Reiss
2009-12-30 15:03 ` [PATCH] fast-import: Document author/committer/tagger name is optional Shawn O. Pearce
2009-12-31 23:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B304987.7030201@facebook.com \
--to=dreiss@facebook.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).