From: Johannes Sixt <j6t@kdbg.org>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Use warning function instead of fprintf(stderr, "Warning: ...").
Date: Mon, 04 Jan 2010 17:02:48 +0100 [thread overview]
Message-ID: <4B421128.5040807@kdbg.org> (raw)
In-Reply-To: <1262463886-8956-1-git-send-email-tfransosi@gmail.com>
Did you actually test any of the changed warnings? You should see extra
empty lines because warning() adds its own LF and you didn't remove any.
-- Hannes
prev parent reply other threads:[~2010-01-04 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 20:24 [PATCH] Use warning function instead of fprintf(stderr, "Warning: ...") Thiago Farina
2010-01-04 16:02 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B421128.5040807@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).