From: Sam Vilain <sam@vilain.net>
To: Eric Wong <normalperson@yhbt.net>
Cc: Andrew Myrick <amyrick@apple.com>, git@vger.kernel.org
Subject: Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick
Date: Thu, 07 Jan 2010 11:38:38 +1300 [thread overview]
Message-ID: <4B4510EE.4090504@vilain.net> (raw)
In-Reply-To: <20100106214338.GA5115@dcvr.yhbt.net>
Eric Wong wrote:
> Andrew Myrick <amyrick@apple.com> wrote:
>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 650c9e5..8c7c034 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -3052,12 +3052,36 @@ sub check_cherry_pick {
>> for my $range ( @ranges ) {
>> delete @commits{_rev_list($range)};
>> }
>> + for my $commit (keys %commits) {
>>
>
> Hi Andrew,
>
> I'll again defer to Sam for Acks on these. Test cases would be nice to
> have, too.
>
They look fine to me, agreed a test case would be nice and make sure the
features aren't lost later inadvertently.
Thanks Andrew,
Sam
next prev parent reply other threads:[~2010-01-06 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:08 [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Andrew Myrick
2010-01-06 20:08 ` [PATCH 2/2] git-svn: handle merge-base failures Andrew Myrick
2010-01-06 21:43 ` [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Eric Wong
2010-01-06 22:38 ` Sam Vilain [this message]
2010-01-07 6:49 ` [spf:guess] " Eric Wong
2010-01-07 9:05 ` [spf:guess] " Sam Vilain
2010-01-06 22:52 ` Andrew Myrick
2010-01-07 0:25 ` Andrew Myrick
2010-01-07 0:25 ` [PATCH 2/2] git-svn: handle merge-base failures Andrew Myrick
2010-01-07 9:50 ` [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Eric Wong
2010-01-21 21:55 ` [PATCH] git-svn: update svn mergeinfo test suite Andrew Myrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4510EE.4090504@vilain.net \
--to=sam@vilain.net \
--cc=amyrick@apple.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).