From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: kusmabite@gmail.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
msysgit@googlegroups.com, git@vger.kernel.org
Subject: Re: [PATCH] mingw: disable Python
Date: Fri, 08 Jan 2010 14:52:47 +0100 [thread overview]
Message-ID: <4B4738AF.9020101@viscovery.net> (raw)
In-Reply-To: <7vpr5kpvmh.fsf@alter.siamese.dyndns.org>
Junio C Hamano schrieb:
> Erik Faye-Lund <kusmabite@googlemail.com> writes:
>>> On Fri, 8 Jan 2010, Johannes Sixt wrote:
>>>> (how do you undefine a Makefile variable?);
>>> How about
>>>
>>> NO_PYTHON=
>>>
>>> in config.mak?
>> That doesn't work for me, at least not out of the box. NO_PYTHON is
>> still defined, it's just defined to an empty string.
>
> I think Dscho is right. "ifdef FOO" yields (and should yield) false if
> FOO is set to empty.
Indeed. Strange. It didn't work when I tested it a few hours ago, but no
it works as you say. According to the docs, 'ifdef' actually does not test
defined-ness, but emptyness. So, Erik's original version is fine:
Acked-by: Johannes Sixt <j6t@kdbg.org>
-- Hannes
next prev parent reply other threads:[~2010-01-08 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 21:52 [PATCH] mingw: enable NO_PYTHON Erik Faye-Lund
2010-01-07 22:00 ` Erik Faye-Lund
2010-01-07 22:07 ` [PATCH] mingw: disable Python Erik Faye-Lund
2010-01-08 8:07 ` Johannes Sixt
2010-01-08 10:35 ` Johannes Schindelin
2010-01-08 10:49 ` Erik Faye-Lund
2010-01-08 13:35 ` Junio C Hamano
2010-01-08 13:52 ` Johannes Sixt [this message]
2010-01-08 13:55 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4738AF.9020101@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).