From: Johannes Sixt <j.sixt@viscovery.net>
To: Richard Weinberger <richard@nod.at>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] Fix variable initialization in insert_packed_refs().
Date: Fri, 15 Jan 2010 08:34:53 +0100 [thread overview]
Message-ID: <4B501A9D.6060703@viscovery.net> (raw)
In-Reply-To: <201001150029.01486.richard@nod.at>
Richard Weinberger schrieb:
> - int cmp = cmp, len;
> + int cmp, len;
If you look around in the code, you'll find more *cough* initializations
*cough* like this. They are written this way for a reason: they avoid
unwarranted compiler warnings "'foo' may be used uninitialized". Are you
saying that this warning is not triggered anymore after your change?
-- Hannes
next prev parent reply other threads:[~2010-01-15 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 23:29 [PATCH 2/2] Fix variable initialization in insert_packed_refs() Richard Weinberger
2010-01-15 7:34 ` Johannes Sixt [this message]
2010-01-15 11:02 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B501A9D.6060703@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).