From: Johannes Sixt <j.sixt@viscovery.net>
To: Fredrik Kuivinen <frekui@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Andrzej K. Haczewski" <ahaczewski@gmail.com>
Subject: Re: [PATCH v3] Threaded grep
Date: Mon, 18 Jan 2010 14:45:44 +0100 [thread overview]
Message-ID: <4B546608.4010503@viscovery.net> (raw)
In-Reply-To: <4c8ef71001180528h6182ef4l8a617fd038bd7318@mail.gmail.com>
Fredrik Kuivinen schrieb:
> On Mon, Jan 18, 2010 at 12:11, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> Fredrik Kuivinen schrieb:
>>> + pthread_mutex_unlock(&grep_lock);
>>> + pthread_cond_signal(&cond_add);
>> Please swap these two lines, so that pthread_cond_signal() is called while
>> the lock is held.
>
> May I ask why? (just curious)
Because our pthreads_cond_* functions on Windows are not POSIXly correct
and work reliably only when pthread_cond_signal() is called while the
mutex is held.
-- Hannes
next prev parent reply other threads:[~2010-01-18 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 10:33 [PATCH v3] Threaded grep Fredrik Kuivinen
2010-01-18 11:11 ` Johannes Sixt
2010-01-18 13:28 ` Fredrik Kuivinen
2010-01-18 13:45 ` Johannes Sixt [this message]
2010-01-18 18:05 ` Linus Torvalds
2010-01-19 7:34 ` Fredrik Kuivinen
2010-01-19 15:41 ` Linus Torvalds
[not found] ` <7vmy0bhxn1.fsf@alter.siamese.dyndns.org>
2010-01-19 0:12 ` Fredrik Kuivinen
2010-01-19 7:03 ` Johannes Sixt
2010-01-25 22:47 ` Fredrik Kuivinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B546608.4010503@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=ahaczewski@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).