From: Sebastian Schuberth <sschuberth@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j.sixt@viscovery.net>,
pgit@pcharlan.com
Subject: Re: [PATCH v2 1/4] engine.pl: Fix a recent breakage of the buildsystem generator
Date: Sat, 23 Jan 2010 00:48:40 +0100 [thread overview]
Message-ID: <4B5A3958.5060505@gmail.com> (raw)
In-Reply-To: <4B5A03EF.1030208@ramsay1.demon.co.uk>
On 22.01.2010 21:00, Ramsay Jones wrote:
> Commit ade2ca0c (Do not try to remove directories when removing
> old links, 27-10-2009) added an expression to a 'test' using an
> '-o' or connective. This resulted in the buildsystem generator
> mistaking a conditional 'rm' for a linker command. In order to
> fix the breakage, we filter out all 'test' commands before then
> attempting to identify the commands of interest.
>
> Signed-off-by: Ramsay Jones<ramsay@ramsay1.demon.co.uk>
> ---
>
> Changes from v1, in response to comments from Pete Harlan and
> Sebastian Schuberth:
>
> - remove second (useless) regex from condition in filter code
> - remove the commented out version of the original filter code
> - re-worded commit message to reflect the above changes
Acked-by: Sebastian Schuberth <sschuberth@gmail.com>
Thanks again!
--
Sebastian Schuberth
prev parent reply other threads:[~2010-01-22 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 20:00 [PATCH v2 1/4] engine.pl: Fix a recent breakage of the buildsystem generator Ramsay Jones
2010-01-22 23:48 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5A3958.5060505@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pgit@pcharlan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).