git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Pursell <bill.pursell@gmail.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org
Subject: Re: shared permissions on COMMIT_EDITMSG
Date: Thu, 28 Jan 2010 07:03:45 -1000	[thread overview]
Message-ID: <4B61C371.4050903@gmail.com> (raw)
In-Reply-To: <20100128111425.GA29577@Knoppix>

Ilari Liusvaara wrote:
> On Wed, Jan 27, 2010 at 11:19:22PM -1000, William Pursell wrote:
>> With git-init --shared=0660 and a umask of 022,
>> the first commit to the repository creates
>> the file COMMIT_EDITMSG with mode 0644
>> instead of 0660.  I believe this is incorrect
>> behavior.  Simple fix:
>  
> COMMIT_EDITMSG is related to committing, committing needs
> working copy, and shared working copies don't work all too
> well (and Git can't do anything about that because all kinds
> of stuff edits the files there, not just Git).
> 
> Shared repository settings are meant to override umasks
> for files in actual repository itself.

For simple work flows (eg recording linear history
of config files), sharing a working directory
works okay except for COMMIT_EDITMSG.  Since
COMMIT_EDITMSG is in the git repository and only
written by git, it makes sense for core.sharedrepository
to be honored.

-- 
William Pursell

  reply	other threads:[~2010-01-28 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28  9:19 shared permissions on COMMIT_EDITMSG William Pursell
2010-01-28 11:14 ` Ilari Liusvaara
2010-01-28 17:03   ` William Pursell [this message]
2010-01-28 17:57     ` demerphq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B61C371.4050903@gmail.com \
    --to=bill.pursell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ilari.liusvaara@elisanet.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).