From: Johannes Sixt <j.sixt@viscovery.net>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] git-gui: use themed tk widgets with Tk 8.5
Date: Tue, 02 Feb 2010 09:25:39 +0100 [thread overview]
Message-ID: <4B67E183.3010800@viscovery.net> (raw)
In-Reply-To: <878wbln0oa.fsf@users.sourceforge.net>
Pat Thoyts schrieb:
> This patch enables the use of themed Tk widgets with Tk 8.5 and above.
With this patch, the sizes of the file lists are not restored correctly
anymore. The upper list (unstage files) always appears in the "native"
size. A fix for this would be appreciated.
However!
It has always been the case that the (restored) height and width of the
list of unstaged files could not be larger than the "original" window size
(i.e., the size before the stored geometry is applied).
Appearently, the pane widgets restrict its sash sizes to their total size,
and the total window geometry was applied only after sash sizes were set.
As a work-around for this problem I have modified git-gui to start up with
a much larger list of unstaged files (400x600 or so) so that the initial
"original" size is also much larger, and then the restored size can be
anything smaller than [this size plus the size of the widgets around it].
This work-around does not work anymore. The list of unstaged files always
opens with the same (tiny) size. .git/config contains this after exiting
git-gui:
[gui]
geometry = 1183x906+88+32 184 204
wmstate = normal
The sash sizes are stored correctly in .git/config, but are not restored.
Perhaps you have an idea to fix this?
(I'm on Windows, btw.)
-- Hannes
next prev parent reply other threads:[~2010-02-02 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 0:05 [PATCH] git-gui: use themed tk widgets with Tk 8.5 Pat Thoyts
2010-01-26 9:17 ` Sverre Rabbelier
2010-01-28 0:51 ` Shawn O. Pearce
2010-01-28 1:45 ` Johannes Schindelin
2010-01-28 1:42 ` Shawn O. Pearce
2010-01-28 2:54 ` Junio C Hamano
2010-01-28 2:56 ` Shawn O. Pearce
2010-01-28 21:20 ` [PATCH] git gui: Quote git path properly when starting another gui in a submodule Jens Lehmann
2010-01-28 23:45 ` Shawn O. Pearce
2010-02-02 8:25 ` Johannes Sixt [this message]
2010-02-02 21:09 ` [PATCH] git-gui: use themed tk widgets with Tk 8.5 Pat Thoyts
-- strict thread matches above, loose matches on Subject: below --
2009-12-20 0:46 Pat Thoyts
2009-12-20 13:16 ` [msysGit] " Johannes Schindelin
2009-12-20 15:23 ` Pat Thoyts
2009-12-20 19:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B67E183.3010800@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).