From: Markus Elfring <Markus.Elfring@web.de>
To: git@vger.kernel.org
Subject: Completion of error handling
Date: Tue, 02 Feb 2010 14:11:59 +0100 [thread overview]
Message-ID: <4B68249F.6070004@web.de> (raw)
Hello,
I would like to point out that some checks for return codes are missing in the source files.
Examples:
Would you like to add more error handling for return values from "pthread_mutex_init" like in the function "start_threads" and from "fprintf" in the function "output_header_lines"?
http://git.kernel.org/?p=git/git.git;a=blob;f=builtin-grep.c;h=0ef849cb84650705ffc840aed8a3fcedbeb48f9a;hb=HEAD#l224
http://git.kernel.org/?p=git/git.git;a=blob;f=builtin-mailinfo.c;h=a50ac2256cdbacd76ed44a50804212be07f949db;hb=HEAD#l935
Regards,
Markus
next reply other threads:[~2010-02-02 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 13:11 Markus Elfring [this message]
2010-02-02 18:26 ` Completion of error handling Nicolas Pitre
2010-02-02 18:49 ` Markus Elfring
2010-02-02 19:27 ` Nicolas Pitre
2010-02-02 19:42 ` Markus Elfring
2010-02-02 19:49 ` Avery Pennarun
2010-02-02 20:10 ` Markus Elfring
2010-02-02 20:25 ` Avery Pennarun
2010-02-02 21:26 ` Markus Elfring
2010-02-02 21:27 ` Avery Pennarun
2010-02-02 21:55 ` Markus Elfring
2010-02-11 13:08 ` Markus Elfring
2010-02-16 10:56 ` Andreas Ericsson
2010-02-18 15:11 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B68249F.6070004@web.de \
--to=markus.elfring@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).