[PATCH] Added hint about using .gitignore in git status while printing untracked files

[PATCH] Added hint about using .gitignore in git status while printing untracked files

[Pavan Kumar Sunkara]

Added hint about using .gitignore in git status while printing untracked files
Basically, many users don't come to know about .gitignore functionality in
their starting stages of git and wonder over how to keep the build or doc files
without tracking by git. So, if we add a line saying about gitignore
while printing
help to add untracked files in git status output, it can be very useful

Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
---
 wt-status.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/wt-status.c b/wt-status.c
index 5807fc3..f17300f 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -100,6 +100,7 @@ static void
wt_status_print_untracked_header(struct wt_status *s)
 	if (!advice_status_hints)
 		return;
 	color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to
include in what will be committed)");
+	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
intentionally untrack it)");
 	color_fprintf_ln(s->fp, c, "#");
 }

--

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

[Peter Krefting]

Pavan Kumar Sunkara:

> +	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
> intentionally untrack it)");

That should be "its", not "it is".

-- 
\\// Peter - http://www.softwolves.pp.se/

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

[Michael J Gruber]

Peter Krefting venit, vidit, dixit 18.02.2010 10:59:
> Pavan Kumar Sunkara:
> 
>> +	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
>> intentionally untrack it)");
> 
> That should be "its", not "it is".
> 

Also, an "or" may make things clearer, and "untrack" is wrong: to
untrack is to stop tracking, but this is about untracked files. So, how
about:

---
 wt-status.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/wt-status.c b/wt-status.c
index 5807fc3..f17300f 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -100,6 +100,7 @@ static void
wt_status_print_untracked_header(struct wt_status *s)
 	if (!advice_status_hints)
 		return;
 	color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to include
in what will be committed)");
+	color_fprintf_ln(s->fp, c, "#   (or add its path to .gitignore to
ignore it permanently)");
 	color_fprintf_ln(s->fp, c, "#");
 }

--

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

[Pavan Kumar Sunkara]

>
> Also, an "or" may make things clearer, and "untrack" is wrong: to
> untrack is to stop tracking, but this is about untracked files. So, how
> about:
>
> ---
>  wt-status.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/wt-status.c b/wt-status.c
> index 5807fc3..f17300f 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -100,6 +100,7 @@ static void
> wt_status_print_untracked_header(struct wt_status *s)
>        if (!advice_status_hints)
>                return;
>        color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to include
> in what will be committed)");
> +       color_fprintf_ln(s->fp, c, "#   (or add its path to .gitignore to
> ignore it permanently)");
>        color_fprintf_ln(s->fp, c, "#");
>  }
>
> --
>

I Think that is good :)

-pavan