From: Johannes Sixt <j.sixt@viscovery.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: Re: [PATCH 1/2] shell setup: clear_local_git_env() function
Date: Tue, 23 Feb 2010 07:49:23 +0100 [thread overview]
Message-ID: <4B837A73.8010406@viscovery.net> (raw)
In-Reply-To: <1266881518-11213-1-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta schrieb:
> +# Clear repo-local GIT_* environment variables. Useful when switching to
> +# another repository (e.g. when entering a submodule)
> +clear_local_git_env() {
> + unset GIT_DIR GIT_WORKTREE GIT_OBJECT_DIRECTORY \
> + GIT_INDEX_FILE GIT_GRAFT_FILE GIT_CONFIG \
> + GIT_NO_REPLACE_OBJECTS
IMO, this list should be in sync with the one you find in
connect.c:git_connect() around line 611. They have the same purpose.
(And, BTW, a vertical list would be more readable than a mixed
horizontal+vertical list, IMVHO.)
-- Hannes
next prev parent reply other threads:[~2010-02-23 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100218203726.GD12660@book.hvoigt.net>
2010-02-22 22:16 ` [PATCH] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 22:43 ` Junio C Hamano
2010-02-22 22:56 ` Giuseppe Bilotta
2010-02-22 23:16 ` Junio C Hamano
2010-02-22 23:31 ` [PATCH 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 6:49 ` Johannes Sixt [this message]
2010-02-23 7:55 ` Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 0/2] clear environment for submodules Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 20:25 ` Jens Lehmann
2010-02-23 8:30 ` [PATCHv2 2/2] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 23:31 ` [PATCH " Giuseppe Bilotta
2010-02-23 0:04 ` [msysGit] [PATCH] " Johannes Schindelin
2010-02-23 21:07 ` Heiko Voigt
2010-02-23 21:47 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B837A73.8010406@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=hvoigt@hvoigt.net \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).