From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH] Wrap RUNTIME_PREFIX warning in a compile-time condition
Date: Tue, 23 Feb 2010 11:10:42 +0100 [thread overview]
Message-ID: <4B83A9A2.5080500@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1002231103170.20986@pacific.mpi-cbg.de>
Johannes Schindelin schrieb:
> On Tue, 23 Feb 2010, Johannes Sixt wrote:
>> Johannes Schindelin schrieb:
>>> On Tue, 23 Feb 2010, Johannes Sixt wrote:
>>>> With this patch, individual developers can disable the warning by setting
>>>>
>>>> BASIC_CFLAGS += -DNO_WARN_RUNTIME_PREFIX
>>>>
>>>> in config.mak.
>>> Would this option not prefer to be a runtime option?
>> No. The warning is utterly useless IMO and extremely annoying, and the
>> only reason that it still survives is because you disagree. ;-)
>
> I have been convinced of things before. It just takes a good argument.
The good argument is:
With this patch in upstream git, I have more time to spend on testing
topics from pu and to write new topics on top of vanilla master because I
don't need to apply my private patch all over the place (and back it out
before I submit patches).
Whether the option is compile-time or runtime is secondary. The option is
*for me*,[*] and I prefer it compile-time. *For you* nothing changes
regardless of compile-time or runtime (or do you think you would set the
option?).
[*] As I said, nobody else seems to complain.
-- Hannes
next prev parent reply other threads:[~2010-02-23 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 8:32 [PATCH] Wrap RUNTIME_PREFIX warning in a compile-time condition Johannes Sixt
2010-02-23 9:42 ` Johannes Schindelin
2010-02-23 9:43 ` Johannes Sixt
2010-02-23 10:03 ` Johannes Schindelin
2010-02-23 10:10 ` Johannes Sixt [this message]
2010-02-23 11:07 ` Johannes Schindelin
2010-02-23 11:42 ` [PATCH] Print RUNTIME_PREFIX warning only when GIT_TRACE is set Johannes Sixt
2010-02-23 12:57 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83A9A2.5080500@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).