From: Jens Lehmann <Jens.Lehmann@web.de>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
msysGit Mailinglist <msysgit@googlegroups.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCHv2 1/2] shell setup: clear_local_git_env() function
Date: Tue, 23 Feb 2010 21:25:24 +0100 [thread overview]
Message-ID: <4B8439B4.9030605@web.de> (raw)
In-Reply-To: <1266913829-14533-2-git-send-email-giuseppe.bilotta@gmail.com>
Am 23.02.2010 09:30, schrieb Giuseppe Bilotta:
> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index 7a09566..f1be832 100644
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -172,6 +172,21 @@ get_author_ident_from_commit () {
> LANG=C LC_ALL=C sed -ne "$pick_author_script"
> }
>
> +# Clear repo-local GIT_* environment variables. Useful when switching to
> +# another repository (e.g. when entering a submodule). See also the env
> +# list in git_connect()
> +clear_local_git_env() {
> + unset GIT_ALTERNATE_OBJECT_DIRECTORIES \
> + GIT_CONFIG \
> + GIT_DIR \
> + GIT_GRAFT_FILE \
> + GIT_INDEX_FILE \
> + GIT_NO_REPLACE_OBJECTS \
> + GIT_OBJECT_DIRECTORY \
> + GIT_WORKTREE
Shouldn't that last one be GIT_WORK_TREE?
> +
> +}
> +
> # Make sure we are in a valid repository of a vintage we understand,
> # if we require to be in a git repository.
> if test -z "$NONGIT_OK"
next prev parent reply other threads:[~2010-02-23 20:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100218203726.GD12660@book.hvoigt.net>
2010-02-22 22:16 ` [PATCH] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 22:43 ` Junio C Hamano
2010-02-22 22:56 ` Giuseppe Bilotta
2010-02-22 23:16 ` Junio C Hamano
2010-02-22 23:31 ` [PATCH 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 6:49 ` Johannes Sixt
2010-02-23 7:55 ` Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 0/2] clear environment for submodules Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 20:25 ` Jens Lehmann [this message]
2010-02-23 8:30 ` [PATCHv2 2/2] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 23:31 ` [PATCH " Giuseppe Bilotta
2010-02-23 0:04 ` [msysGit] [PATCH] " Johannes Schindelin
2010-02-23 21:07 ` Heiko Voigt
2010-02-23 21:47 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8439B4.9030605@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=hvoigt@hvoigt.net \
--cc=j.sixt@viscovery.net \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).