From: Johannes Sixt <j.sixt@viscovery.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
msysGit Mailinglist <msysgit@googlegroups.com>,
Jens Lehmann <Jens.Lehmann@web.de>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCHv3 2/5] connect: use static list of repo-local env vars
Date: Wed, 24 Feb 2010 08:14:05 +0100 [thread overview]
Message-ID: <4B84D1BD.2030908@viscovery.net> (raw)
In-Reply-To: <1266968136-11129-3-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta schrieb:
> - /* remove these from the environment */
You shouldn't remove this comment.
> - const char *env[] = {
> - ALTERNATE_DB_ENVIRONMENT,
> - DB_ENVIRONMENT,
> - GIT_DIR_ENVIRONMENT,
> - GIT_WORK_TREE_ENVIRONMENT,
> - GRAFT_ENVIRONMENT,
> - INDEX_ENVIRONMENT,
> - NO_REPLACE_OBJECTS_ENVIRONMENT,
> - NULL
> - };
> - conn->env = env;
> + conn->env = local_repo_env;
IMO, you should squash this patch and the previous one under the subject
"Move list of repo-local environment variables to a public place", and
that public place could be environment.c instead of a new file cache.c
(the name "cache.c" is definitely wrong).
-- Hannes
next prev parent reply other threads:[~2010-02-24 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 23:35 [PATCHv3 0/5] repo-local env vars handling Giuseppe Bilotta
2010-02-23 23:35 ` [PATCHv3 1/5] cache: static list of repo-local env vars Giuseppe Bilotta
2010-02-23 23:35 ` [PATCHv3 2/5] connect: use " Giuseppe Bilotta
2010-02-24 7:14 ` Johannes Sixt [this message]
2010-02-24 7:33 ` Giuseppe Bilotta
2010-02-23 23:35 ` [PATCHv3 3/5] rev-parse: --local-env-vars option Giuseppe Bilotta
2010-02-23 23:35 ` [PATCHv3 4/5] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 23:35 ` [PATCHv3 5/5] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B84D1BD.2030908@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Jens.Lehmann@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=hvoigt@hvoigt.net \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).