git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Heiko Voigt <hvoigt@hvoigt.net>,
	msysGit Mailinglist <msysgit@googlegroups.com>,
	Jens Lehmann <Jens.Lehmann@web.de>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCHv4 6/6] is_submodule_modified(): clear environment properly
Date: Wed, 24 Feb 2010 10:18:42 +0100	[thread overview]
Message-ID: <4B84EEF2.2030502@viscovery.net> (raw)
In-Reply-To: <cb7bb73a1002240055v58953dcfh3be7c4589523b14b@mail.gmail.com>

Giuseppe Bilotta schrieb:
> On Wed, Feb 24, 2010 at 9:06 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> Giuseppe Bilotta schrieb:
>>> +     const char *env[local_repo_env_size+2];
>> Variable sized arrays are prohibited.
> 
> Ah, sorry. Is alloca() allowed? I don't see it being used anywhere
> else in the code, and malloc would be a little too much for this case.

in cache.h:

#define LOCAL_REPO_ENV_CAPACITY 20
const char *const l_r_e[];

in environtment.c:

const char *const l_r_e[LOCAL_REPO_ENV_CAPACITY] = { ..., NULL };

and the compiler will croak if the constant becomes too small. (Oh, I
know, you must use the 'inconsistent mode' that I nit-picked if you use
this approach.)

-- Hannes

  reply	other threads:[~2010-02-24  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  7:23 [PATCHv4 0/6] repo-local env vars handling Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 1/6] environment: static list of repo-local env vars Giuseppe Bilotta
2010-02-24 15:58   ` Junio C Hamano
2010-02-24 19:20     ` Giuseppe Bilotta
2010-02-24 19:36       ` Junio C Hamano
2010-02-24 23:11         ` Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 2/6] connect: use " Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 3/6] rev-parse: --local-env-vars option Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 4/6] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 5/6] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-24  7:23 ` [PATCHv4 6/6] is_submodule_modified(): clear environment properly Giuseppe Bilotta
2010-02-24  8:06   ` Johannes Sixt
2010-02-24  8:55     ` Giuseppe Bilotta
2010-02-24  9:18       ` Johannes Sixt [this message]
2010-02-24 10:07         ` Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B84EEF2.2030502@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Jens.Lehmann@web.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=hvoigt@hvoigt.net \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).