From: Johannes Sixt <j6t@kdbg.org>
To: Frank Li <lznuaa@gmail.com>
Cc: git@vger.kernel.org, davvid@gmail.com
Subject: Re: [PATCH v2 1/3] git-svn: Support retrieving passwords with GIT_ASKPASS
Date: Fri, 26 Feb 2010 18:41:02 +0100 [thread overview]
Message-ID: <4B8807AE.2090502@kdbg.org> (raw)
In-Reply-To: <1267142845-3040-1-git-send-email-lznuaa@gmail.com>
Frank Li schrieb:
> +if (! exists $ENV{GIT_ASKPASS}) {
> + if (exists $ENV{SSH_ASKPASS}) {
> + $ENV{GIT_ASKPASS} = $ENV{SSH_ASKPASS};
> + if ($^O eq 'msys') {
> + $ENV{GIT_ASKPASS} =~ s/\\/\\\\/g;
> + $ENV{GIT_ASKPASS} =~ s/(.*)/"$1"/;
Don't quote GIT_ASKPASS here.
> + if (exists $ENV{GIT_ASKPASS}) {
> + open(PH, "$ENV{GIT_ASKPASS} \"$prompt\" |");
open(PH, "-|", $ENV{GIT_ASKPASS}, $prompt);
and you don't have to do any quoting at all, no?
-- Hannes
prev parent reply other threads:[~2010-02-26 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3.SQo>
2010-02-26 0:07 ` [PATCH v2 1/3] git-svn: Support retrieving passwords with GIT_ASKPASS Frank Li
2010-02-26 6:33 ` Junio C Hamano
2010-02-26 8:55 ` Frank Li
2010-02-26 10:05 ` Eric Wong
2010-02-26 17:41 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8807AE.2090502@kdbg.org \
--to=j6t@kdbg.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).