From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Pete Harlan <pgit@pcharlan.com>
Cc: Vladimir Panteleev <vladimir@thecybershadow.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: "git stash list" shows HEAD reflog
Date: Sat, 13 Mar 2010 23:07:45 +0100 [thread overview]
Message-ID: <4B9C0CB1.3000308@lsrfire.ath.cx> (raw)
In-Reply-To: <4B9C0713.30407@pcharlan.com>
Am 13.03.2010 22:43, schrieb Pete Harlan:
> On 03/13/2010 09:37 AM, René Scharfe wrote:
>> As Vladimir reported, "git log -g refs/stash" surprisingly showed the reflog
>> of HEAD if the message in the reflog file was too long. To fix this, convert
>> for_each_recent_reflog_ent() to use strbuf_getwholeline() instead of fgets(),
>> for safety and to avoid any size limits for reflog entries.
>
> Was the old code actually unsafe? If not, then perhaps the commit
> message would be clearer if ", for safety and" were removed.
The function silently dropped valid (if long) reflog entries on the
floor. It's certainly debatable if not doing so is "safer" or merely
"more complete". The sentence is already long enough in any case, so I
don't mind dropping this part.
René
prev parent reply other threads:[~2010-03-13 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 14:52 "git stash list" shows HEAD reflog Vladimir Panteleev
2010-03-13 17:37 ` René Scharfe
2010-03-13 17:41 ` Dave Olszewski
2010-03-13 20:11 ` René Scharfe
2010-03-13 21:21 ` Re: [git] " Dave Olszewski
2010-03-13 21:49 ` René Scharfe
2010-03-13 22:47 ` [PATCH] don't use default revision if a rev was specified Dave Olszewski
2010-03-13 23:19 ` René Scharfe
2010-03-14 6:57 ` Junio C Hamano
2010-03-13 21:43 ` "git stash list" shows HEAD reflog Pete Harlan
2010-03-13 22:07 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9C0CB1.3000308@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pgit@pcharlan.com \
--cc=vladimir@thecybershadow.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).