Re: [patch 02/15] const-expr.patch

[Johannes Sixt <j.sixt@viscovery.net>]

Gary V. Vaughan schrieb:
> Unfortunately, there are still plenty of production systems with
> vendor compilers that choke unless all compound declarations can be
> determined statically at compile time, for example hpux10.20 (I can
> provide a comprehensive list of our supported platforms that exhibit
> this problem if necessary).

Yes, a comprehensive list would be appreciated. This change is an
uglification that I personally would prefer to stay out of the code base
unless many consumers of git are hurt.

The problem with this non-feature is that it is all too easy that new code
introduces new incompatibilities.

> Index: b/ll-merge.c
> ===================================================================
> --- a/ll-merge.c
> +++ b/ll-merge.c

BTW, did you notice that git is a version control system that hosts itself? ;)

> +	dict[0].placeholder = "O"; dict[0].value = temp[0];
> +	dict[1].placeholder = "A"; dict[1].value = temp[1];
> +	dict[2].placeholder = "B"; dict[2].value = temp[2];
> +	dict[3].placeholder = "L"; dict[3].value = temp[3];
> +	dict[3].placeholder = NULL; dict[3].value = NULL;

	dict[4]...

-- Hannes