git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Mark Lodato <lodatom@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Fix indentation problem in git-ls-files(1)
Date: Wed, 17 Mar 2010 07:47:10 +0100	[thread overview]
Message-ID: <4BA07AEE.2080100@viscovery.net> (raw)
In-Reply-To: <m2pr34kpzm.fsf@igel.home>

Andreas Schwab schrieb:
> Johannes Sixt <j.sixt@viscovery.net> writes:
> 
>> Andreas Schwab schrieb:
>>> The nested list in the description of the -t option wasn't properly
>>> indented.  Additionally, make it a horizontal labeled list since the
>>> labels are all short.
>> IMHO, converting a vertical list to a horizontal list is a step in the
>> wrong direction, even if the labels are short. It is far easier to scan a
>> vertical list for a match than a horizontal list.
> 
> The linebreak after the label is useless when all labels are much
> shorter than the indentation.

I use Junio's man pages, and they look like so:

       -t
           Identify the file status with the following tags
           (followed by a space) at the start of each line:

           H   cached
           S   skip-worktree
           M   unmerged
           R   removed/deleted
           C   modified/changed
           K   to be killed
           ?   other

and the HTML version at
http://www.kernel.org/pub/software/scm/git/docs/git-ls-files.html looks OK
as well. I see nothing that needs fixing in either case.

-- Hannes

  reply	other threads:[~2010-03-17  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 14:32 [PATCH] Fix indentation problem in git-ls-files(1) Andreas Schwab
2010-03-04 23:37 ` Junio C Hamano
2010-03-05 10:08   ` Andreas Schwab
2010-03-07 17:27     ` Mark Lodato
2010-03-07 18:38       ` Junio C Hamano
2010-03-15 22:49       ` Andreas Schwab
2010-03-15 23:12         ` Junio C Hamano
2010-03-16  7:05         ` Johannes Sixt
2010-03-16 19:47           ` Andreas Schwab
2010-03-17  6:47             ` Johannes Sixt [this message]
2010-03-19 18:55               ` Andreas Schwab
2010-03-20 14:01                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA07AEE.2080100@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lodatom@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).