From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH] Fix indentation problem in git-ls-files(1) Date: Wed, 17 Mar 2010 07:47:10 +0100 Message-ID: <4BA07AEE.2080100@viscovery.net> References: <7v3a0fr740.fsf@alter.siamese.dyndns.org> <4B9F2DB0.30400@viscovery.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , Mark Lodato , git@vger.kernel.org To: Andreas Schwab X-From: git-owner@vger.kernel.org Wed Mar 17 07:47:21 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nrn2H-0003f3-6r for gcvg-git-2@lo.gmane.org; Wed, 17 Mar 2010 07:47:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219Ab0CQGrQ (ORCPT ); Wed, 17 Mar 2010 02:47:16 -0400 Received: from lilzmailso01.liwest.at ([212.33.55.23]:4579 "EHLO lilzmailso01.liwest.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550Ab0CQGrP (ORCPT ); Wed, 17 Mar 2010 02:47:15 -0400 Received: from cpe228-254.liwest.at ([81.10.228.254] helo=theia.linz.viscovery) by lilzmailso01.liwest.at with esmtpa (Exim 4.69) (envelope-from ) id 1Nrn27-0007OV-Hl; Wed, 17 Mar 2010 07:47:11 +0100 Received: from [127.0.0.1] (J6T.linz.viscovery [192.168.1.95]) by theia.linz.viscovery (Postfix) with ESMTP id 2BBD41660F; Wed, 17 Mar 2010 07:47:11 +0100 (CET) User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) In-Reply-To: X-Enigmail-Version: 0.95.5 X-Spam-Score: -1.4 (-) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Andreas Schwab schrieb: > Johannes Sixt writes: > >> Andreas Schwab schrieb: >>> The nested list in the description of the -t option wasn't properly >>> indented. Additionally, make it a horizontal labeled list since the >>> labels are all short. >> IMHO, converting a vertical list to a horizontal list is a step in the >> wrong direction, even if the labels are short. It is far easier to scan a >> vertical list for a match than a horizontal list. > > The linebreak after the label is useless when all labels are much > shorter than the indentation. I use Junio's man pages, and they look like so: -t Identify the file status with the following tags (followed by a space) at the start of each line: H cached S skip-worktree M unmerged R removed/deleted C modified/changed K to be killed ? other and the HTML version at http://www.kernel.org/pub/software/scm/git/docs/git-ls-files.html looks OK as well. I see nothing that needs fixing in either case. -- Hannes