From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Scott Chacon <schacon@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] Prompt for a username when an HTTP request 401s
Date: Fri, 19 Mar 2010 00:53:32 +0100 [thread overview]
Message-ID: <4BA2BCFC.9070600@lsrfire.ath.cx> (raw)
In-Reply-To: <20100318190309.GC10981@spearce.org>
Am 18.03.2010 20:03, schrieb Shawn O. Pearce:
> Scott Chacon <schacon@gmail.com> wrote:
>> +static void get_http_user_name()
>> +{
>> + user_name = xstrdup(getpass("Username: "));
>
> Why are we getting the username via a password prompt where echo
> has been disabled? Traditionally a username field is obtained as
> echoed input.
>
> Also, this method shouldn't be named get_*() if its returning void.
> Sounds far to funny. init_http_user_name()? prompt_for_user_name()?
Or inline the one-liner at its single call-site?
René
next prev parent reply other threads:[~2010-03-18 23:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 18:57 [PATCH] Prompt for a username when an HTTP request 401s Scott Chacon
2010-03-18 19:03 ` Shawn O. Pearce
2010-03-18 23:53 ` René Scharfe [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-19 3:41 Scott Chacon
2010-03-19 9:13 ` Tay Ray Chuan
2010-03-19 9:34 ` Daniel Stenberg
2010-03-19 14:16 ` Shawn O. Pearce
2010-03-19 14:32 ` Shawn O. Pearce
2010-03-19 19:08 ` Scott Chacon
2010-03-19 19:09 ` Shawn O. Pearce
2010-03-19 19:27 ` Junio C Hamano
2010-03-19 19:17 Scott Chacon
2010-04-01 20:29 Scott Chacon
2010-04-01 21:30 ` Junio C Hamano
2010-04-01 22:06 ` Scott Chacon
2010-04-01 22:14 Scott Chacon
2010-04-02 6:39 ` Junio C Hamano
2010-04-02 15:43 ` Scott Chacon
2010-04-02 16:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA2BCFC.9070600@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=schacon@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).