From: A Large Angry SCM <gitzilla@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Alexander Gladysh <agladysh@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] gitk: refresh index before checking for local changes
Date: Tue, 06 Apr 2010 22:21:55 -0400 [thread overview]
Message-ID: <4BBBEC43.5000100@gmail.com> (raw)
In-Reply-To: <20100407004353.GA11346@progeny.tock>
Jonathan Nieder wrote:
> Most git porcelain silently refreshes stat-dirty index entries. Teach
> gitk to, too; this will make the behavior easier to understand when a
> person makes a change to a file and then changes mind and restores the
> old version in her editor of choice.
>
> This patch does not change the ‘checkout’ code path, since it is
> assumed that the index is already being cleaned in that case.
>
> Testing is needed to check if this breaks operation with read-only
> access to a repository.
>
NAK - gitk should not modify a repository and/or working dir unless
_explicitly_ prompted to by the user.
If you want a new _non-default_ option setting for gitk, that fine also.
next prev parent reply other threads:[~2010-04-07 2:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:57 gitk pays too much attention to file timestamps Alexander Gladysh
2010-04-06 23:15 ` Markus Heidelberg
2010-04-06 23:36 ` Jonathan Nieder
2010-04-06 23:47 ` Alexander Gladysh
2010-04-07 0:43 ` [PATCH/RFC] gitk: refresh index before checking for local changes Jonathan Nieder
2010-04-07 1:07 ` Alexander Gladysh
2010-04-07 1:16 ` Jonathan Nieder
2010-04-07 2:21 ` A Large Angry SCM [this message]
2010-04-07 2:57 ` Jonathan Nieder
2010-04-07 5:47 ` Junio C Hamano
2010-04-07 11:21 ` A Large Angry SCM
2010-04-07 16:48 ` Avery Pennarun
2010-04-07 14:36 ` Jon Seymour
2010-04-06 23:58 ` gitk pays too much attention to file timestamps Avery Pennarun
2010-04-07 1:01 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBBEC43.5000100@gmail.com \
--to=gitzilla@gmail.com \
--cc=agladysh@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).